Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving coalescing registration to TUs #2076

Merged
merged 1 commit into from Apr 8, 2016

Conversation

Projects
None yet
2 participants
@sithhell
Copy link
Member

commented Apr 6, 2016

This patch moves the parcel coalescing registration macros from the
headers into the translation units.

flyby: remove boost::mpl from base_lco and some minor header cleanup

This also fixes a memory leak reported from LeakSanitizer

@sithhell sithhell added this to the 0.9.12 milestone Apr 6, 2016

typedef typename boost::mpl::if_<
boost::is_same<void, Result>, util::unused_type, Result
typedef typename std::conditional<
std::is_same<void, Result>::value, util::unused_type, Result
>::type result_type;

This comment has been minimized.

Copy link
@hkaiser

hkaiser Apr 6, 2016

Member

Why not use std::is_void<Result>::value instead?

This comment has been minimized.

Copy link
@sithhell

sithhell Apr 6, 2016

Author Member

Good point. I will change that.

template<> \
inline char const* get_action_coalescing_name<Action>() \
template<> HPX_ALWAYS_EXPORT \
char const* get_action_coalescing_name<Action>() \

This comment has been minimized.

Copy link
@hkaiser

hkaiser Apr 6, 2016

Member

What's your rationale for this change?

This comment has been minimized.

Copy link
@sithhell

sithhell Apr 6, 2016

Author Member

The rationale is that we don't really have to have the get_action_coalescing_name definition in each translation unit. We have the same already for get_action_name.

This comment has been minimized.

Copy link
@sithhell

sithhell Apr 6, 2016

Author Member

In addition, this change silenced the memory leak report I got.

@sithhell sithhell force-pushed the coalescing branch from 0b393de to efbefb8 Apr 6, 2016

@hkaiser

This comment has been minimized.

Copy link
Member

commented Apr 6, 2016

LGTM, thanks!

Moving coalescing registration to TUs
This patch moves the parcel coalescing registration macros from the
headers into the translation units.

flyby: remove boost::mpl from base_lco and some minor header cleanup

@sithhell sithhell merged commit b258953 into master Apr 8, 2016

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@sithhell sithhell deleted the coalescing branch Apr 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.