Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making sure multiple components are properly initialized from arguments #2335

Merged
merged 1 commit into from Sep 21, 2016

Conversation

Projects
None yet
3 participants
@hkaiser
Copy link
Member

commented Sep 17, 2016

  • this fixes #2323
  • added regression test

@hkaiser hkaiser added this to the 1.0.0 milestone Sep 17, 2016

@hkaiser hkaiser force-pushed the fixing_2323 branch from 3fee29f to 4f9d0de Sep 18, 2016

@sithhell
Copy link
Member

left a comment

LGTM except for the missing include in the test.

@hkaiser hkaiser force-pushed the fixing_2323 branch from 4f9d0de to 6f2435e Sep 19, 2016

@hkaiser

This comment has been minimized.

Copy link
Member Author

commented Sep 19, 2016

@sithhell That should be fixed now, thanks!

@hkaiser

This comment has been minimized.

Copy link
Member Author

commented Sep 21, 2016

@sithhell Could you approve this PR, please?

@sithhell sithhell merged commit ac8c1d5 into master Sep 21, 2016

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@sithhell sithhell deleted the fixing_2323 branch Sep 21, 2016

@@ -651,9 +651,11 @@ namespace hpx { namespace components { namespace server
// Note, T and Ts can't be (non-const) references, and parameters
// should be moved to allow for move-only constructor argument
// types.

This comment has been minimized.

Copy link
@K-ballo

K-ballo Sep 21, 2016

Member

This note ought to be amended now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.