Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wait_or_add_new returning thread_id_type #2495

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
2 participants
@sithhell
Copy link
Member

commented Feb 10, 2017

Instead of pushing the newly available work to the pending queues,
wait_or_add_new now returns a newly created thread_data pointer to
be used in the scheduling loop.


if (scheduler.SchedulingPolicy::wait_or_add_new(
num_thread, running, idle_loop_count))
bool running = this_state.load() < state_stopping;

This comment has been minimized.

This comment has been minimized.

Copy link
@sithhell

sithhell Feb 15, 2017

Author Member

Good catch.

@sithhell sithhell force-pushed the wait_or_add_new_improvement branch from f082a42 to beb649e Feb 15, 2017

wait_or_add_new returning thread_id_type
Instead of pushing the newly available work to the pending queues,
wait_or_add_new now returns a newly created thread_data pointer to
be used in the scheduling loop.

@sithhell sithhell force-pushed the wait_or_add_new_improvement branch from beb649e to fda7093 Feb 15, 2017

@hkaiser

This comment has been minimized.

Copy link
Member

commented Apr 18, 2017

@sithhell This needs some fixes before it can be merged. Should it still go into the V1.0 release?

@sithhell

This comment has been minimized.

Copy link
Member Author

commented May 9, 2017

Closing as it doesn't show any benefit, makes perfomance worse.

@sithhell sithhell closed this May 9, 2017

@sithhell sithhell deleted the wait_or_add_new_improvement branch May 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.