Fix tuple serialization #2505
Merged
Fix tuple serialization #2505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkaiser
reviewed
Feb 15, 2017
| @@ -174,7 +174,7 @@ namespace hpx { namespace parcelset { namespace policies { namespace mpi | |||
| int ret = 0; | |||
| ret = MPI_Test(&r, &completed, status); | |||
| HPX_ASSERT(ret == MPI_SUCCESS); | |||
| if(completed)// && status->MPI_ERROR != MPI_ERR_PENDING) | |||
| if(completed) | |||
There was a problem hiding this comment.
What's the rationale of this change?
There was a problem hiding this comment.
Just deleting the comment. The code was never used and is not required.
hkaiser
reviewed
Feb 15, 2017
| struct is_bitwise_serializable< | ||
| ::hpx::util::tuple<Ts...> | ||
| ::hpx::util::detail::tuple_impl<Is, Ts...> |
sithhell
force-pushed
the
fix_tuple_serialization
branch
from
085a509
to
a4c4982
Compare
added 2 commits
February 15, 2017 15:44
Only tuple_impl<Is, Ts...> should be bitwise serialized
- Removed commented code - Removed unnecessary call to request_done - Removing impossible check in tag_provider
sithhell
force-pushed
the
fix_tuple_serialization
branch
from
a4c4982
to
62a16f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only tuple_impl<Is, Ts...> should be bitwise serialized
Flyby: Cleaning up MPI parcelport.