Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HPX_WITH_MALLOC easier to use #2542

Merged
merged 2 commits into from Mar 19, 2017

Conversation

Projects
None yet
2 participants
@neundorf
Copy link
Contributor

commented Mar 17, 2017

This branch does two things:

  • it makes HPX_WITH_MALLOC non-advanced, so it is eaier to find e.g. in cmake-gui, which is good since probably most users have to modify this settings
  • it adds an STRINGS keyword to hpx_option(), and uses this to set the STRINGS cache property, so that the options are presented in a combobox in cmake-gui (and so really easy to select). Use this for HPX_WITH_MALLOC.

neundorf added some commits Mar 17, 2017

- add STRINGS option to hpx_option() and use it for HPX_WITH_MALLOC
This patch adds a STRINGS option to hpx_option(), which is then used
to set the STRINGS cache property. This has the effect that in cmake-gui
the strings are presented in a combobox.

Alex
- cmake option HPX_WITH_MALLOC: make it non-advanced
Since probably more or less every use has to modify this option,
it is better if it is not ADVANCED.

Alex
@hkaiser

This comment has been minimized.

Copy link
Member

commented Mar 17, 2017

LGTM, thanks!

@hkaiser hkaiser merged commit 6d9c9c3 into STEllAR-GROUP:master Mar 19, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.