Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First attempt to introduce spmd_block in hpx #2592

Merged
merged 14 commits into from Apr 23, 2017

Conversation

Projects
None yet
2 participants
@atrantan
Copy link
Contributor

commented Apr 20, 2017

This PR tries to introduce code related to spmd_block that was presented here http://stellar.cct.lsu.edu/pubs/extending_cpp_with_coarray_semantics_2016.pdf
A major difference in comparaison to what was presented in that paper is that an image is no longer considered as a computation located in an explicit locality. It is now a simple sequential computation able to cooperate with other ones.

@atrantan

This comment has been minimized.

Copy link
Contributor Author

commented Apr 20, 2017

@hkaiser

This comment has been minimized.

Copy link
Member

commented Apr 21, 2017

Now inspect is not happy with this anymore: https://6489-4455628-gh.circle-artifacts.com/0/tmp/circle-artifacts.ksvyahZ/hpx_inspect_report.html

Also, I don't think replacing std::ref with boost::ref is the correct fix for the issue you were seeing.

@atrantan atrantan force-pushed the atrantan:spmd_block_local_release branch from 3bfbc34 to eeecfa8 Apr 21, 2017

atrantan added some commits Apr 21, 2017

atrantan
atrantan

@atrantan atrantan force-pushed the atrantan:spmd_block_local_release branch from 28ec500 to 2f10ac3 Apr 21, 2017

@atrantan atrantan force-pushed the atrantan:spmd_block_local_release branch from 2f10ac3 to 249a01d Apr 21, 2017

hpx::wait_all(join);

delete(c1);
delete(c2);

This comment has been minimized.

Copy link
@hkaiser

hkaiser Apr 22, 2017

Member

Wouldn't it be much easier if you wrote:

boost::atomic<std::size_t> c1(0);
hpx::parallel::v2::define_spmd_block(  
     num_images, std::move(bulk_test), &c1);  

IIRC, there is no need to dynamically allocate the atomic variable.

atrantan

@hkaiser hkaiser merged commit 5b1aaf0 into STEllAR-GROUP:release Apr 23, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@hkaiser hkaiser added this to the 1.0.0 milestone Apr 23, 2017

@atrantan atrantan deleted the atrantan:spmd_block_local_release branch May 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.