Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove slashes before CMAKE_FILES_DIRECTORY variables #2713

Merged
merged 1 commit into from Jun 25, 2017

Conversation

Projects
None yet
2 participants
@Naios
Copy link
Contributor

commented Jun 24, 2017

Something I came across while working on my GSoC Project:

As stated by https://cmake.org/Wiki/CMake_Useful_Variables CMAKE_FILES_DIRECTORY contains a leading slash already, and should be used as following with the current binary directory: ${CMAKE_CURRENT_BINARY_DIR}${CMAKE_FILES_DIRECTORY}.
Otherwise this will lead to paths with double slashes.

I did find & replace, probably this should work if the CI reports green.

Remove slashes before CMAKE_FILES_DIRECTORY variables
* As stated by https://cmake.org/Wiki/CMake_Useful_Variables
  CMAKE_FILES_DIRECTORY contains a leading slash already,
  and should be used as following with the current binary directory:
  `${CMAKE_CURRENT_BINARY_DIR}${CMAKE_FILES_DIRECTORY}`.
  Otherwise this will lead to paths with double slashes.
@hkaiser
Copy link
Member

left a comment

LGTM, even if this is not really a big thing to leave in...

@hkaiser hkaiser merged commit ef98ce5 into STEllAR-GROUP:master Jun 25, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.