Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Implemented segmented algorithms for partitioned vector #2725
Tasks completed as part of GSoC project (See: #1338) -
All algorithms have associated passing tests in the unit/parallel/segmented_algorithms folder.
Implemented segmented algorithms extending existing parallel algorithms
Implemented segmented algorithms for partitioned vector
changed the title from
Jun 29, 2017
referenced this pull request
Jun 29, 2017
@ajaivgeorge I don't see any other problems besides those mentioned by Hartmut already. For the scan, it makes sense to verify if
@hkaiser can we enforce a CI build on AppVeyor? It seems it failed due to a network problem.
@ajaivgeorge, @mcopik: two of the new tests are failing in distributed runs, see here for an example: http://rostam.cct.lsu.edu/builders/hpx_gcc_4_9_4_boost_1_56_centos_x86_64_release/builds/126/steps/run_unit_tests/logs/stdio
Could you fix those asap, please?
@hkaiser @mcopik, The error has been fixed in my master branch. The issue was with the util/loop accumulate function that I added. During the PR review when i changed from using a temp iterator to using first iterator directly i forgot to add a ++first. Hadn't run the test after this change.
I have tested the algorithm upto localities=5. The other algorithms like transform_scan test and for_each and transform also work for localities > 2. But the following tests fail for localities > 2
These might be failing because the tests are designed for localities=2 (especially the extensive tests for the scans) or because of something fundamental with the algorithm. I will look into this once I am done with the find algorithms.