Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some other warnings and errors detected by clang 5.0 #2769

Merged
merged 2 commits into from Jul 20, 2017

Conversation

Projects
None yet
2 participants
@atrantan
Copy link
Contributor

commented Jul 19, 2017

This patch tries to remove some other warnings and errors detected by clang 5.0 (Cuda Clang being enabled)

@@ -129,8 +129,10 @@ namespace hpx { namespace parallel { inline namespace v1
operator()(Iter part_begin, std::size_t part_size,
std::size_t /*part_index*/)
{
#if !defined(__NVCC__) && !defined(__CUDACC__)

This comment has been minimized.

Copy link
@hkaiser

hkaiser Jul 19, 2017

Member

As this might cause problems in other places of the code, wouldn't it be better to provide an empty implementation of annotate_function for this configuration?

This comment has been minimized.

Copy link
@atrantan

atrantan Jul 19, 2017

Author Contributor

Done in 0420d00

@hkaiser
Copy link
Member

left a comment

LGTM, thanks!

@hkaiser hkaiser merged commit 776c713 into STEllAR-GROUP:master Jul 20, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.