Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sync_images() method to spmd_block class #2773

Merged
merged 3 commits into from Aug 10, 2017

Conversation

Projects
None yet
2 participants
@atrantan
Copy link
Contributor

commented Jul 20, 2017

This patch adds a new method for spmd_block class called sync_images() to synchronize only a subset of images as opposed to sync_all(). The chosen approach is to manage concurrentlly a map of barriers that is expanded each time a new combination of image ids is given via a sync_images() call. Local and distributed versions have been implemented and unit tests have been changed to test those features.

@atrantan atrantan force-pushed the atrantan:spmd_block_with_sync_images branch 5 times, most recently from dbbb12e to 23dcaa9 Jul 20, 2017

@hkaiser hkaiser added this to the 1.1.0 milestone Jul 21, 2017

@atrantan atrantan force-pushed the atrantan:spmd_block_with_sync_images branch from f03f154 to 02f8329 Jul 22, 2017

atrantan

@atrantan atrantan force-pushed the atrantan:spmd_block_with_sync_images branch from 02f8329 to 6faad89 Jul 22, 2017

@hkaiser

hkaiser approved these changes Aug 9, 2017

Copy link
Member

left a comment

I don't like to use of the term 'image' in this context, but otherwise this LGTM. Thanks

@hkaiser

This comment has been minimized.

Copy link
Member

commented Aug 9, 2017

@atrantan Would you be able to create some documentation for this, please?

@hkaiser hkaiser merged commit 58f1171 into STEllAR-GROUP:master Aug 10, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@atrantan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2017

@hkaiser Done in c60a41d

@atrantan atrantan deleted the atrantan:spmd_block_with_sync_images branch Aug 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.