Master fixes #3022
Merged
Master fixes #3022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkaiser
reviewed
Nov 22, 2017
| @@ -316,6 +316,8 @@ namespace lcos { | |||
| : ptr_(o.ptr_.release(), &wrapping_deleter) | |||
| {} | |||
|
|
|||
| keep_alive& operator=(keep_alive&& o) = default; | |||
|
|
|||
There was a problem hiding this comment.
Should we add a default copy assignment operator as well?
There was a problem hiding this comment.
No. This thing is obviously not copyable
There was a problem hiding this comment.
Hmm, that's not really obvious to me. If the intention is to inhibit copying, add a =delete for the corresponding functions.
|
It's already implicitly deleted due to the `unique_ptr` member. This is an
internal helper only anyways and not intended for public use.
|
|
Ok, you're right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fixes to master: