Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master fixes #3022

Merged
merged 2 commits into from Nov 24, 2017

Conversation

Projects
None yet
2 participants
@sithhell
Copy link
Member

commented Nov 22, 2017

Small fixes to master:

  • cosmetic addition of promise_lco::keep_alive default move assignment
  • Fixing c&p errors for operator> in optional after constexpr 'fixes'
@hkaiser
Copy link
Member

left a comment

LGTM, thanks!

@@ -316,6 +316,8 @@ namespace lcos {
: ptr_(o.ptr_.release(), &wrapping_deleter)
{}

keep_alive& operator=(keep_alive&& o) = default;

This comment has been minimized.

Copy link
@hkaiser

hkaiser Nov 22, 2017

Member

Should we add a default copy assignment operator as well?

This comment has been minimized.

Copy link
@sithhell

sithhell Nov 23, 2017

Author Member

No. This thing is obviously not copyable

This comment has been minimized.

Copy link
@hkaiser

hkaiser Nov 23, 2017

Member

Hmm, that's not really obvious to me. If the intention is to inhibit copying, add a =delete for the corresponding functions.

@sithhell

This comment has been minimized.

Copy link
Member Author

commented Nov 23, 2017

@hkaiser

This comment has been minimized.

Copy link
Member

commented Nov 23, 2017

Ok, you're right.

@hkaiser
Copy link
Member

left a comment

LGTM, thanks!

@sithhell sithhell merged commit 4685364 into master Nov 24, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@sithhell sithhell deleted the master_fixes branch Nov 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.