Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify use of yield/yield_k #3090

Merged
merged 2 commits into from Jan 11, 2018

Conversation

Projects
None yet
2 participants
@hkaiser
Copy link
Member

commented Jan 1, 2018

  • cleanup configuration of TLS and compiler specific fence operation

@hkaiser hkaiser added this to the 1.1.0 milestone Jan 1, 2018

Unify use of yield/yield_k
- cleanup configuration of TLS and compiler specific fence operation

@hkaiser hkaiser force-pushed the fixing_yield branch from 00d5eeb to 16e51e5 Jan 1, 2018

#endif

#if !defined(HPX_NATIVE_TLS)
# if defined(_GLIBCXX_HAVE_TLS)

This comment has been minimized.

Copy link
@sithhell

sithhell Jan 8, 2018

Member

There needs to be at least one C++ header include to have this define, maybe #include <cstdint>?

This comment has been minimized.

Copy link
@sithhell

sithhell Jan 8, 2018

Member

Or even <ciso646>...

This comment has been minimized.

Copy link
@hkaiser

hkaiser Jan 8, 2018

Author Member

Fair point, will fix. Thanks!

This comment has been minimized.

Copy link
@hkaiser

hkaiser Jan 10, 2018

Author Member

Done.

@sithhell
Copy link
Member

left a comment

Thanks, LGTM!

@hkaiser hkaiser merged commit 2bff68d into master Jan 11, 2018

4 of 5 checks passed

pycicle daint-6.2.0 Test errors 1
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
pycicle daint-6.2.0 Build errors 0
Details
pycicle daint-6.2.0 Config errors 0
Details

@hkaiser hkaiser deleted the fixing_yield branch Jan 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.