Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding performance_counter::reinit to allow for dynamically changing counter sets #3118

Merged
merged 2 commits into from Jan 24, 2018

Conversation

Projects
None yet
2 participants
@hkaiser
Copy link
Member

commented Jan 21, 2018

  • This change adds a new API function for performance counters that instructs a
    counter to re-initialize the set of values it refers to
  • This also adds a new hpx::reinit_active_counters() API that triggers a
    reinit for all active counters

Any background context you want to provide?

We will need this functionality for the new performance counters to be created for Phylanx where the list of values to be returned from a performance counter may change dynamically based on the evaluated expressions.

@hkaiser

This comment has been minimized.

Copy link
Member Author

commented Jan 21, 2018

@parsa This is a functionality you will need to use for the new Phylanx performance counters. After compiling the expression trees an application now should call hpx::reinit_active_counters() that will trigger re-scanning of the existing primitive instances inside the counters.

@hkaiser hkaiser force-pushed the reinit_counters branch from ac55fa6 to 9fff8c6 Jan 22, 2018

Adding performance_counter::reinit to allow for dynamically changing …
…counter sets

- This change adds a new API function for performance counters that instructs a
  counter to re-initialize the set of counters it refers to
- This also adds a new `hpx::reinit_active_counters()` API that triggers a
  reinit for all active counters

@hkaiser hkaiser force-pushed the reinit_counters branch from 9fff8c6 to b33d059 Jan 22, 2018

@hkaiser hkaiser force-pushed the reinit_counters branch from b33d059 to 62548ec Jan 23, 2018

@parsa

parsa approved these changes Jan 24, 2018

Copy link
Contributor

left a comment

It works and looks fine.

@hkaiser hkaiser merged commit 83ab578 into master Jan 24, 2018

7 of 8 checks passed

pycicle daint-6.2.0 Test errors 1
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
pycicle daint-6.0.0 Build errors 0
Details
pycicle daint-6.0.0 Config errors 0
Details
pycicle daint-6.0.0 Test errors 0
Details
pycicle daint-6.2.0 Build errors 0
Details
pycicle daint-6.2.0 Config errors 0
Details

@hkaiser hkaiser deleted the reinit_counters branch Jan 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.