Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally disable printing of diagnostics during terminate. #3188

Merged
merged 1 commit into from Feb 23, 2018

Conversation

Projects
None yet
3 participants
@hkaiser
Copy link
Member

commented Feb 22, 2018

This also removes the call to std::abort in the termination handler as the system is aborting anyways.

Optionally disable printing of diagnostics during terminate.
This also removes the call to std::abort in the termination handler as the system is aborting anyways.
@parsa

parsa approved these changes Feb 22, 2018

Copy link
Contributor

left a comment

Works as intended.

@sithhell

This comment has been minimized.

Copy link
Member

commented Feb 22, 2018

Out of curiosity, what's the original problem this PR is addressing?

@hkaiser

This comment has been minimized.

Copy link
Member Author

commented Feb 22, 2018

Out of curiosity, what's the original problem this PR is addressing?

If you work with Python loading modules that depend on HPX, then forcefully existing the python interpreter causes HPX to print the full debug info trace, which is just confusing. This allows to disable printing things, if required.

@hkaiser hkaiser merged commit a4c18bd into master Feb 23, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@hkaiser hkaiser deleted the termination_handler branch Feb 23, 2018

sithhell added a commit that referenced this pull request Mar 13, 2018

Readding accidently removed std::abort
This abort was removed with #3188.

sithhell added a commit that referenced this pull request Mar 15, 2018

Readding accidently removed std::abort
This abort was removed with #3188.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.