Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new cuda kernel synchronization with hpx::future demo #3292

Merged
merged 1 commit into from May 4, 2018

Conversation

biddisco
Copy link
Contributor

@biddisco biddisco commented Apr 17, 2018

This example shows how to launch a kuda kernel and bind it to
an hpx::future so that continuations may be attached to it
in the same way as a CPU task.

A new helper class is introduced that can be used with the old
cuBlas +future example code. This commit unifies the two to make a
cleaner integration.

The cuda_future_helper might benefit from being moved into the main
hpx::compute tree rather than being in examples.

This example shows how to launch a kuda kernel and bind it to
an hpx::future so that continuations may be attached to it
in the same way as a CPU task.

A new helper class is introduced that can be used with the old
cuBlas +future example code. This commit unifies the two to make a
cleaner integration.

The cuda_future_helper might benefit from being moved into the main
hpx::compute tree rather than being in examples.
Copy link
Member

@sithhell sithhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this helper. It should really live inside of hpx::compute. It is a great addition to have for supporting regular CUDA kernels.

@hkaiser
Copy link
Member

hkaiser commented May 4, 2018

Let's go ahead with this. We can always move the code into the core, if needed.

@hkaiser hkaiser merged commit 585cf8d into master May 4, 2018
@hkaiser hkaiser deleted the cuda_futures branch May 4, 2018 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants