Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix partitioned vector include in partitioned_vector_find tests #3294

Merged

Conversation

Projects
None yet
2 participants
@msimberg
Copy link
Contributor

commented Apr 18, 2018

Fixes failures like these.

@msimberg msimberg force-pushed the msimberg:fix-partitioned-vector-includes branch from 350f486 to e3eef68 Apr 18, 2018

@msimberg

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2018

The move that clang_tidy is complaining about looks intentional. Is it?

@hkaiser

This comment has been minimized.

Copy link
Member

commented Apr 19, 2018

The move that clang_tidy is complaining about looks intentional. Is it?

This is a genuine bug, should be using std::forward instead.

@msimberg

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2018

Thanks @hkaiser, changed it.

@msimberg msimberg force-pushed the msimberg:fix-partitioned-vector-includes branch from 0ef0b1f to de58783 Apr 19, 2018

@hkaiser

This comment has been minimized.

Copy link
Member

commented Apr 19, 2018

Thanks @msimberg, much appreciated!

@hkaiser
Copy link
Member

left a comment

LGTM, thanks!

@msimberg msimberg changed the title WIP: Fix partitioned vector include in partitioned_vector_find tests Fix partitioned vector include in partitioned_vector_find tests Apr 20, 2018

@msimberg msimberg merged commit 1d38121 into STEllAR-GROUP:master Apr 20, 2018

42 of 46 checks passed

ci/circleci: install Your tests failed on CircleCI
Details
pycicle daint-3294-clang-6.0.0 Build errors 2
Details
pycicle daint-3294-clang-6.0.0 Test errors 1
Details
pycicle daint-3294-clang-6.0.0-Boost-1.65.0-Debug Test errors 1
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: clang_tidy Your tests passed on CircleCI!
Details
ci/circleci: configure Your tests passed on CircleCI!
Details
ci/circleci: core Your tests passed on CircleCI!
Details
ci/circleci: examples Your tests passed on CircleCI!
Details
ci/circleci: inspect Your tests passed on CircleCI!
Details
ci/circleci: tests.headers.compat Your tests passed on CircleCI!
Details
ci/circleci: tests.headers.components Your tests passed on CircleCI!
Details
ci/circleci: tests.headers.compute Your tests passed on CircleCI!
Details
ci/circleci: tests.headers.config Your tests passed on CircleCI!
Details
ci/circleci: tests.headers.include Your tests passed on CircleCI!
Details
ci/circleci: tests.headers.lcos Your tests passed on CircleCI!
Details
ci/circleci: tests.headers.parallel Your tests passed on CircleCI!
Details
ci/circleci: tests.headers.performance_counters Your tests passed on CircleCI!
Details
ci/circleci: tests.headers.plugins Your tests passed on CircleCI!
Details
ci/circleci: tests.headers.runtime Your tests passed on CircleCI!
Details
ci/circleci: tests.headers.traits Your tests passed on CircleCI!
Details
ci/circleci: tests.headers.util Your tests passed on CircleCI!
Details
ci/circleci: tests.performance Your tests passed on CircleCI!
Details
ci/circleci: tests.regressions Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.actions Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.agas Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.build Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.component Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.computeapi Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.diagnostics Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.lcos Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.parallel Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.parcelset Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.performance_counter Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.resource Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.serialization Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.threads Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.traits Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.util Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
pycicle daint-3294-clang-6.0.0 Config errors 0
Details
pycicle daint-3294-clang-6.0.0-Boost-1.65.0-Debug Build errors 0
Details
pycicle daint-3294-clang-6.0.0-Boost-1.65.0-Debug Config errors 0
Details
pycicle daint-3294-gcc-6.2.0 Build errors 0
Details
pycicle daint-3294-gcc-6.2.0 Config errors 0
Details
pycicle daint-3294-gcc-6.2.0 Test errors 0
Details

@msimberg msimberg deleted the msimberg:fix-partitioned-vector-includes branch Apr 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.