Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pu-step and pu-offset command line options #3313

Merged
merged 1 commit into from May 13, 2018

Conversation

Projects
None yet
3 participants
@msimberg
Copy link
Contributor

commented May 9, 2018

Fixes #3300.

Proposed Changes

  • Make sure pu masks and thread occupancy are used/computed correctly when using pu-step and pu-offset command line options.
@msimberg

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2018

And it looks like I broke --hpx:bind=none in the process. Still need some time with this.

@msimberg msimberg force-pushed the msimberg:fix-pu-offset-step branch from c1939ce to 2415fd5 May 9, 2018

@hkaiser hkaiser added this to the 1.2.0 milestone May 9, 2018

@biddisco
Copy link
Contributor

left a comment

LGTM

@hkaiser

This comment has been minimized.

Copy link
Member

commented May 11, 2018

@msimberg is --hpx:bind=none fixed now? Can this be merged?

@msimberg

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2018

@hkaiser yes, sorry, --hpx:bind=none is back to normal now. Merging.

@msimberg msimberg merged commit a452255 into STEllAR-GROUP:master May 13, 2018

50 of 51 checks passed

ci/circleci: install Your tests failed on CircleCI
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: clang_tidy Your tests passed on CircleCI!
Details
ci/circleci: configure Your tests passed on CircleCI!
Details
ci/circleci: core Your tests passed on CircleCI!
Details
ci/circleci: examples Your tests passed on CircleCI!
Details
ci/circleci: inspect Your tests passed on CircleCI!
Details
ci/circleci: tests.headers.compat Your tests passed on CircleCI!
Details
ci/circleci: tests.headers.components Your tests passed on CircleCI!
Details
ci/circleci: tests.headers.compute Your tests passed on CircleCI!
Details
ci/circleci: tests.headers.config Your tests passed on CircleCI!
Details
ci/circleci: tests.headers.include Your tests passed on CircleCI!
Details
ci/circleci: tests.headers.lcos Your tests passed on CircleCI!
Details
ci/circleci: tests.headers.parallel Your tests passed on CircleCI!
Details
ci/circleci: tests.headers.performance_counters Your tests passed on CircleCI!
Details
ci/circleci: tests.headers.plugins Your tests passed on CircleCI!
Details
ci/circleci: tests.headers.runtime Your tests passed on CircleCI!
Details
ci/circleci: tests.headers.traits Your tests passed on CircleCI!
Details
ci/circleci: tests.headers.util Your tests passed on CircleCI!
Details
ci/circleci: tests.performance Your tests passed on CircleCI!
Details
ci/circleci: tests.regressions Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.actions Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.agas Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.build Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.component Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.computeapi Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.diagnostics Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.lcos Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.parallel.algorithms Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.parallel.block Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.parallel.container_algorithms Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.parallel.datapar_algorithms Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.parallel.executors Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.parallel.segmented_algorithms Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.parcelset Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.performance_counter Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.resource Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.serialization Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.threads Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.traits Your tests passed on CircleCI!
Details
ci/circleci: tests.unit.util Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
pycicle daint-3313-clang-6.0.0-Boost-1.65.0-Debug Build errors 0
Details
pycicle daint-3313-clang-6.0.0-Boost-1.65.0-Debug Config errors 0
Details
pycicle daint-3313-clang-6.0.0-Boost-1.65.0-Debug Test errors 0
Details
pycicle daint-3313-clang-6.0.0-Boost-1.65.0-Release Build errors 0
Details
pycicle daint-3313-clang-6.0.0-Boost-1.65.0-Release Config errors 0
Details
pycicle daint-3313-clang-6.0.0-Boost-1.65.0-Release Test errors 0
Details
pycicle daint-no-networking-3313-clang-6.0.0-Boost-1.65.0-Debug Build errors 0
Details
pycicle daint-no-networking-3313-clang-6.0.0-Boost-1.65.0-Debug Config errors 0
Details
pycicle daint-no-networking-3313-clang-6.0.0-Boost-1.65.0-Debug Test errors 0
Details

@msimberg msimberg deleted the msimberg:fix-pu-offset-step branch May 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.