Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable (existing) code for extracting stack pointer on Power platform #3469

Merged
merged 2 commits into from Feb 1, 2019

Conversation

Projects
None yet
4 participants
@hkaiser
Copy link
Member

commented Sep 27, 2018

@khuck this might solve the stackoverflows we're seeing on your Power9 platform. Please verify.

Enable (existing) code for extracting stack pointer on Power platform
- fix calculation of remaining stack space for boost context

@hkaiser hkaiser force-pushed the stackptr_powerpc branch from b33188f to e16d382 Sep 27, 2018

@sithhell
Copy link
Member

left a comment

LGTM!

@hkaiser

This comment has been minimized.

Copy link
Member Author

commented Oct 1, 2018

This still does not solve the issues we're seeing (STEllAR-GROUP/phylanx#584). We need to keep investigating things...

@msimberg msimberg removed this from the 1.2.0 milestone Nov 1, 2018

@sithhell sithhell merged commit f04a978 into master Feb 1, 2019

13 of 17 checks passed

build-and-test Workflow: build-and-test
Details
pycicle daint-clang-3.8-boost-1.58.0-c++11-Release Test errors 4
Details
pycicle daint-gcc-7.3.0-cuda-9.2.148_3.19-6.0.7.1_2.1__g3d9acc8-boost-1.68.0-c++11-Release Build errors 50
Details
pycicle daint-gcc-7.3.0-cuda-9.2.148_3.19-6.0.7.1_2.1__g3d9acc8-boost-1.68.0-c++11-Release Test errors 9
Details
ci/gitlab/stackptr_powerpc Pipeline passed on GitLab
Details
pycicle daint-clang-3.8-boost-1.58.0-c++11-Release Build errors 0
Details
pycicle daint-clang-3.8-boost-1.58.0-c++11-Release Config errors 0
Details
pycicle daint-clang-7.0-boost-1.68.0-c++17-nonetworking-Debug Build errors 0
Details
pycicle daint-clang-7.0-boost-1.68.0-c++17-nonetworking-Debug Config errors 0
Details
pycicle daint-clang-7.0-boost-1.68.0-c++17-nonetworking-Debug Test errors 0
Details
pycicle daint-gcc-4.9.3-boost-1.58.0-c++11-Debug Build errors 0
Details
pycicle daint-gcc-4.9.3-boost-1.58.0-c++11-Debug Config errors 0
Details
pycicle daint-gcc-4.9.3-boost-1.58.0-c++11-Debug Test errors 0
Details
pycicle daint-gcc-7.3.0-boost-1.68.0-c++17-Release Build errors 0
Details
pycicle daint-gcc-7.3.0-boost-1.68.0-c++17-Release Config errors 0
Details
pycicle daint-gcc-7.3.0-boost-1.68.0-c++17-Release Test errors 0
Details
pycicle daint-gcc-7.3.0-cuda-9.2.148_3.19-6.0.7.1_2.1__g3d9acc8-boost-1.68.0-c++11-Release Config errors 0
Details

@sithhell sithhell deleted the stackptr_powerpc branch Feb 1, 2019

@khuck

This comment has been minimized.

Copy link
Contributor

commented Feb 10, 2019

@sithhell @hkaiser since this was merged into master on Feb 1, I am seeing the error return for Power8 when compiled with GCC 7.1 or Clang 7 - for all HPX programs, even simple hello world or fibonacci:

{what}: Stack overflow: HPX(out_of_memory)

terminate called after throwing an instance of 'hpx::detail::exception_with_info<hpx::exception>'
  what():  Stack overflow: HPX(out_of_memory)
./build-hpx.sh: line 70: 33088 Aborted                 (core dumped) ./bin/fibonacci

The HPX commit right before this one 5364e25 works fine.

@hkaiser

This comment has been minimized.

Copy link
Member Author

commented Feb 10, 2019

@khuck either our stack overflow detection is wrong or the stack overflow is real. How do we find out?

@khuck

This comment has been minimized.

Copy link
Contributor

commented Feb 10, 2019

@hkaiser The default for Linux is off, and I don’t set it. Should I?

@khuck

This comment has been minimized.

Copy link
Contributor

commented Feb 10, 2019

@hkaiser enabling HPX_WITH_STACKOVERFLOW_DETECTION gives the same result.

@hkaiser

This comment has been minimized.

Copy link
Member Author

commented Feb 10, 2019

@khuck: @sithhell knows all of this code better than I. Let's see what he has to say.

@sithhell

This comment has been minimized.

Copy link
Member

commented Feb 10, 2019

This is very odd, I'll have to run it myself and see what's happening then.

@msimberg msimberg added this to the 1.3.0 milestone May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.