Extend Cmake for building hpx as distribution packages (refs #3575) #3585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkaiser
reviewed
Dec 8, 2018
bmwiedemann
reviewed
Dec 8, 2018
There was a problem hiding this comment.
- There is a typo in "infrastructures" in the commit message,
- once everyone is happy, the commits probably should be squashed together to make the git history more readable - use
git rebase --interactive origin/master - it is still "openSUSE", not openSuse (in the PR description ;-)
|
junghans
previously approved these changes
Dec 9, 2018
@bmwiedemann, from your comment in #3575 (comment) I thought "openSUSE" is the correct capitalization, right? |
msimberg
reviewed
Dec 13, 2018
diehlpk
force-pushed
the
openSUSEpatch
branch
2 times, most recently
from
502c42c
to
0864c2f
Compare
diehlpk
force-pushed
the
openSUSEpatch
branch
from
0864c2f
to
cc01393
Compare
|
@junghans yes, openSUSE is the correct way, but look at this PR's description... |
|
I see @diehlpk can edit this! |
|
@msimberg Again it is failing for cuda ans my changes within cmake should not affect this. Could you please merge the branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes #3575
Proposed Changes
Any background context you want to provide?
Building the rpm packages Fedora's build infrastructure or openSuse's build infrastructure requires to disable some optimization, since we do not know of the target architecture provide it.