Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging the executor-enabled overloads of shared_future<>::then #3637

Merged
merged 1 commit into from Jan 31, 2019

Conversation

Projects
None yet
4 participants
@chinz07
Copy link
Contributor

commented Jan 28, 2019

The separate overload for thread executors caused problems since
the implementation of then requires a scheduled_executor and not
just an executor.

The merged overload still does not test if the user-provided executor
does actually satisfy the requirements of a scheduled_executor.
Since future<>::then does exhibit the same issue, this should be
fixed in a separate PR.

This commit also adds a regression test demonstrating the issue.

This fixes issue #3634.

@hkaiser
Copy link
Member

left a comment

Very nice, thanks a lot!

Merge the executor-enabled overloads of shared_future<>::then
The separate overload for thread executors caused problems since
the implementation of `then` requires a `scheduled_executor` and not
just an `executor`.

The merged overload still does not test if the user-provided executor
does actually satisfy the requirements of a `scheduled_executor`.
Since future<>::then does exhibit the same issue, this should be
fixed in a separate commit.

This commit also adds a regression test demonstrating the issue.

This fixes issue #3634.

@chinz07 chinz07 force-pushed the chinz07:fixing_3634 branch from e6ebc8f to a2cbd6f Jan 30, 2019

@sithhell sithhell merged commit 54edaae into STEllAR-GROUP:master Jan 31, 2019

8 of 10 checks passed

pycicle daint-gcc-4.9.3-boost-1.58.0-c++11-Debug Test errors 1
Details
pycicle daint-gcc-7.3.0-boost-1.68.0-c++17-Release Test errors 1
Details
build-and-test Workflow: build-and-test
Details
pycicle daint-clang-7.0-boost-1.68.0-c++17-nonetworking-Debug Build errors 0
Details
pycicle daint-clang-7.0-boost-1.68.0-c++17-nonetworking-Debug Config errors 0
Details
pycicle daint-clang-7.0-boost-1.68.0-c++17-nonetworking-Debug Test errors 0
Details
pycicle daint-gcc-4.9.3-boost-1.58.0-c++11-Debug Build errors 0
Details
pycicle daint-gcc-4.9.3-boost-1.58.0-c++11-Debug Config errors 0
Details
pycicle daint-gcc-7.3.0-boost-1.68.0-c++17-Release Build errors 0
Details
pycicle daint-gcc-7.3.0-boost-1.68.0-c++17-Release Config errors 0
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.