Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to tackle timeouts during startup #3644

Merged
merged 2 commits into from Feb 1, 2019

Conversation

Projects
None yet
3 participants
@sithhell
Copy link
Member

commented Feb 1, 2019

This PR enables the deadlock detection for our spinlocks and unlocks the lock before throwing an exception during loading of components.

@msimberg
Copy link
Contributor

left a comment

Good idea!

@sithhell sithhell merged commit d40fdf8 into master Feb 1, 2019

2 checks passed

build-and-test Workflow: build-and-test
Details
ci/gitlab/fix_timeout Pipeline passed on GitLab
Details

@sithhell sithhell deleted the fix_timeout branch Feb 1, 2019

@hkaiser

This comment has been minimized.

Copy link
Member

commented Feb 3, 2019

This didn't fix the timeouts :/ (https://circleci.com/gh/STEllAR-GROUP/hpx/58464)

@hkaiser hkaiser added this to the 1.3.0 milestone Feb 3, 2019

@sithhell

This comment has been minimized.

Copy link
Member Author

commented Feb 4, 2019

No, migrate_component suffers from a different problem than those at startup... no idea what yet...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.