Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing race between setting and getting the value inside future_data #3663

Merged
merged 1 commit into from Feb 5, 2019

Conversation

Projects
None yet
3 participants
@sithhell
Copy link
Member

commented Feb 5, 2019

Avoid race between future_data_base::wait and
future_data_base::set_value/future_data_base::set_exception which
was observed in parcelhandler::sync_put_parcel (see #3656).

Fixing race between setting and getting the value inside future_data
Avoid race between `future_data_base::wait` and
`future_data_base::set_value`/`future_data_base::set_exception` which
was observed in `parcelhandler::sync_put_parcel` (see #3656).

@sithhell sithhell force-pushed the fix_future_data_race branch from 2fb91a1 to dde89ad Feb 5, 2019

@hkaiser

hkaiser approved these changes Feb 5, 2019

Copy link
Member

left a comment

Nice solution!

@sithhell sithhell merged commit 6e35d04 into master Feb 5, 2019

1 of 2 checks passed

build-and-test Workflow: build-and-test
Details
ci/gitlab/fix_future_data_race Pipeline passed on GitLab
Details

@hkaiser hkaiser deleted the fix_future_data_race branch Feb 5, 2019

msimberg added a commit that referenced this pull request Feb 6, 2019

@msimberg msimberg modified the milestones: 1.3.0, 1.2.1 Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.