Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing yet another race in future_data #3666

Merged
merged 1 commit into from Feb 6, 2019

Conversation

Projects
None yet
2 participants
@sithhell
Copy link
Member

commented Feb 6, 2019

Run the completion handlers as static functions.
With this change, completion handlers can not have
exceptions that escape the handler as this would lead
to silently swallow the exceptions.
Previously, this would have triggered a "promise_already_satisfied"
error. This is wrong behavior, exceptions escaping completion
handling should be considered a bug. always.

Fixing yet another race in future_data
Run the completion handlers as static functions.
With this change, completion handlers can not have
exceptions that escape the handler as this would lead
to silently swallow the exceptions.
Previously, this would have triggered a "promise_already_satisfied"
error. This is wrong behavior, exceptions escaping completion
handling should be considered a bug. always.

@sithhell sithhell added this to the 1.2.1 milestone Feb 6, 2019

@hkaiser

hkaiser approved these changes Feb 6, 2019

Copy link
Member

left a comment

LGTM, thanks!

@sithhell sithhell merged commit b4e066e into master Feb 6, 2019

1 of 2 checks passed

build-and-test Workflow: build-and-test
Details
ci/gitlab/fix_completion_handling Pipeline passed on GitLab
Details

@sithhell sithhell deleted the fix_completion_handling branch Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.