Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a couple of test failures #3687

Merged
merged 3 commits into from Feb 12, 2019

Conversation

Projects
None yet
3 participants
@msimberg
Copy link
Contributor

commented Feb 11, 2019

  • Handles pending and pending_boost states correctly in set_thread_state. When going from pending to pending_boost or vice versa the thread should not be scheduled again. This would sometimes cause this assert to fire:
    HPX_ASSERT(it != thread_map_.end());
  • Ignore registered locks while calling interruption_point in thread test
  • Flyby: fix check for valid states in get_thread_state_name
@hkaiser
Copy link
Member

left a comment

Nice find!

msimberg added some commits Feb 11, 2019

Handle pending and pending_boost states correctly in set_thread_state
Make sure threads that are already pending or pending_boost don't get
rescheduled if the new state is pending (when old state was pending_boost) or
vice versa.

@msimberg msimberg force-pushed the msimberg:timeouts branch from 75a255a to 8e208b6 Feb 12, 2019

@sithhell sithhell merged commit 356ded4 into STEllAR-GROUP:master Feb 12, 2019

2 of 7 checks passed

build-and-test Workflow: build-and-test
Details
pycicle daint-clang-3.8-boost-1.58.0-c++11-Release Build errors 13
Details
pycicle daint-clang-3.8-boost-1.58.0-c++11-Release Test errors 5
Details
pycicle daint-gcc-7.3.0-cuda-9.2.148_3.19-6.0.7.1_2.1__g3d9acc8-boost-1.68.0-c++11-Release Build errors 50
Details
pycicle daint-gcc-7.3.0-cuda-9.2.148_3.19-6.0.7.1_2.1__g3d9acc8-boost-1.68.0-c++11-Release Test errors 10
Details
pycicle daint-clang-3.8-boost-1.58.0-c++11-Release Config errors 0
Details
pycicle daint-gcc-7.3.0-cuda-9.2.148_3.19-6.0.7.1_2.1__g3d9acc8-boost-1.68.0-c++11-Release Config errors 0
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.