Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename PAGE_SIZE to PAGE_SIZE_ because AppleClang #3759

Merged
merged 1 commit into from Apr 1, 2019

Conversation

Projects
None yet
3 participants
@parsa
Copy link
Contributor

commented Mar 28, 2019

PAGE_SIZE is a macro in Apple Clang.

Proposed Changes

  • Rename the PAGE_SIZE constant in examples/quickstart/component_with_custom_heap.cpp to PAGE_SIZE_.

Any background context you want to provide?

...
CompileC cmake-build-debug/examples/quickstart/HPX.build/Debug/component_with_custom_heap.build/Objects-normal/x86_64/component_with_custom_heap.o examples/quickstart/component_with_custom_heap.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
    cd /Users/parsa/Repositories/hpx
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -x c++ -arch x86_64 -fmessage-length=204 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0 -fcolor-diagnostics -Wno-trigraphs -fpascal-strings -O0 -Wno-missing-field-initializers -Wno-missing-prototypes -Wno-return-type -Wno-non-virtual-dtor -Wno-overloaded-virtual -Wno-exit-time-destructors -Wno-missing-braces -Wparentheses -Wswitch -Wno-unused-function -Wno-unused-label -Wno-unused-parameter -Wno-unused-variable -Wunused-value -Wno-empty-body -Wno-uninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wno-constant-conversion -Wno-int-conversion -Wno-bool-conversion -Wno-enum-conversion -Wno-float-conversion -Wno-non-literal-null-conversion -Wno-objc-literal-conversion -Wno-shorten-64-to-32 -Wno-newline-eof -Wno-c++11-extensions -DCMAKE_INTDIR=\"Debug\" -DHPX_APPLICATION_NAME=component_with_custom_heap -DHPX_APPLICATION_STRING=\"component_with_custom_heap\" -DHPX_PREFIX=\"/Users/parsa/Repositories/hpx/cmake-install-debug\" -DHPX_APPLICATION_EXPORTS -D_GNU_SOURCE -D_DEBUG -DDEBUG -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk -fasm-blocks -fstrict-aliasing -Wdeprecated-declarations -Winvalid-offsetof -mmacosx-version-min=10.14 -g -Wno-sign-conversion -Wno-infinite-recursion -Wno-move -Wno-comma -Wno-block-capture-autoreleasing -Wno-strict-prototypes -Wno-range-loop-analysis -Wno-semicolon-before-method-body -I/Users/parsa/Repositories/hpx/cmake-build-debug/bin/Debug/include -I/Users/parsa/Repositories/hpx -I/Users/parsa/Repositories/hpx/cmake-build-debug -I/Users/parsa/Repositories/hpx/tests -I/Users/parsa/Repositories/hpx/examples -isystem /usr/local/include -I/Users/parsa/Repositories/hpx/cmake-build-debug/examples/quickstart/HPX.build/Debug/component_with_custom_heap.build/DerivedSources-normal/x86_64 -I/Users/parsa/Repositories/hpx/cmake-build-debug/examples/quickstart/HPX.build/Debug/component_with_custom_heap.build/DerivedSources/x86_64 -I/Users/parsa/Repositories/hpx/cmake-build-debug/examples/quickstart/HPX.build/Debug/component_with_custom_heap.build/DerivedSources -Wmost -Wno-four-char-constants -Wno-unknown-pragmas -F/Users/parsa/Repositories/hpx/cmake-build-debug/bin/Debug -std=c++17 -pthread -ftemplate-depth=256 -Wall -Wextra -Wno-unused-local-typedefs -Wno-strict-aliasing -Wno-sign-promo -Wno-attributes -Wno-cast-align -Wno-unused-parameter -Wformat=2 -Wno-format-nonliteral -Winit-self -Wdouble-promotion -Wcast-qual -Wcast-align -Werror=parentheses -Werror=reorder -Werror=return-type -Werror=sequence-point -Werror=uninitialized -Werror=format -Werror=missing-braces -Werror=sign-compare -fdiagnostics-show-option -Werror=vla -MMD -MT dependencies -MF /Users/parsa/Repositories/hpx/cmake-build-debug/examples/quickstart/HPX.build/Debug/component_with_custom_heap.build/Objects-normal/x86_64/component_with_custom_heap.d --serialize-diagnostics /Users/parsa/Repositories/hpx/cmake-build-debug/examples/quickstart/HPX.build/Debug/component_with_custom_heap.build/Objects-normal/x86_64/component_with_custom_heap.dia -c /Users/parsa/Repositories/hpx/examples/quickstart/component_with_custom_heap.cpp -o /Users/parsa/Repositories/hpx/cmake-build-debug/examples/quickstart/HPX.build/Debug/component_with_custom_heap.build/Objects-normal/x86_64/component_with_custom_heap.o
/Users/parsa/Repositories/hpx/examples/quickstart/component_with_custom_heap.cpp:38:31: error: expected unqualified-id
    HPX_CONSTEXPR std::size_t PAGE_SIZE = 16384;
                              ^
In file included from /Users/parsa/Repositories/hpx/examples/quickstart/component_with_custom_heap.cpp:16:
In file included from /Users/parsa/Repositories/hpx/hpx/include/actions.hpp:14:
In file included from /Users/parsa/Repositories/hpx/hpx/runtime/actions/make_continuation.hpp:12:
In file included from /Users/parsa/Repositories/hpx/hpx/runtime/actions/continuation_impl.hpp:10:
In file included from /Users/parsa/Repositories/hpx/hpx/runtime/applier/apply.hpp:20:
In file included from /Users/parsa/Repositories/hpx/hpx/runtime/parcelset/put_parcel.hpp:9:
In file included from /Users/parsa/Repositories/hpx/hpx/runtime.hpp:26:
In file included from /Users/parsa/Repositories/hpx/hpx/util/runtime_configuration.hpp:16:
In file included from /Users/parsa/Repositories/hpx/hpx/util/plugin/dll.hpp:20:
In file included from /Users/parsa/Repositories/hpx/hpx/util/plugin/detail/dll_dlopen.hpp:37:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/mach-o/dyld.h:31:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/mach-o/loader.h:35:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/mach/machine.h:67:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/mach/machine/vm_types.h:33:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/mach/i386/vm_types.h:73:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/mach/i386/vm_param.h:98:33: note: expanded from macro 'PAGE_SIZE'
#define PAGE_SIZE               I386_PGBYTES
                                ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/mach/i386/vm_param.h:95:33: note: expanded from macro 'I386_PGBYTES'
#define I386_PGBYTES            4096            /* bytes per 80386 page */
                                ^
1 error generated.

** BUILD FAILED **
@hkaiser
Copy link
Member

left a comment

LGTM, thanks!

@parsa

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2019

No idea what tests.examples.transpose.transpose_block_numa is or why it fails. But this PR is definitely unrelated to it.

@msimberg

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2019

@parsa yep, definitely unrelated to this PR. I'll have a look. Could be related to #3566.

@msimberg msimberg merged commit d883a33 into master Apr 1, 2019

10 of 17 checks passed

build-and-test Workflow: build-and-test
Details
pycicle daint-clang-7.0-boost-1.68.0-c++17-nonetworking-Debug Test errors 1
Details
pycicle daint-gcc-7.3.0-boost-1.68.0-c++17-Release Build errors 11
Details
pycicle daint-gcc-7.3.0-boost-1.68.0-c++17-Release Test errors 1
Details
pycicle daint-gcc-7.3.0-cuda-9.2.148_3.19-6.0.7.1_2.1__g3d9acc8-boost-1.68.0-c++11-Release Build errors 48
Details
pycicle daint-gcc-7.3.0-cuda-9.2.148_3.19-6.0.7.1_2.1__g3d9acc8-boost-1.68.0-c++11-Release Test errors 8
Details
ci/gitlab/PAGE_SIZE_appleclang Pipeline pending on GitLab
Details
pycicle daint-clang-3.8-boost-1.58.0-c++11-Release Build errors 0
Details
pycicle daint-clang-3.8-boost-1.58.0-c++11-Release Config errors 0
Details
pycicle daint-clang-3.8-boost-1.58.0-c++11-Release Test errors 0
Details
pycicle daint-clang-7.0-boost-1.68.0-c++17-nonetworking-Debug Build errors 0
Details
pycicle daint-clang-7.0-boost-1.68.0-c++17-nonetworking-Debug Config errors 0
Details
pycicle daint-gcc-4.9.3-boost-1.58.0-c++11-Debug Build errors 0
Details
pycicle daint-gcc-4.9.3-boost-1.58.0-c++11-Debug Config errors 0
Details
pycicle daint-gcc-4.9.3-boost-1.58.0-c++11-Debug Test errors 0
Details
pycicle daint-gcc-7.3.0-boost-1.68.0-c++17-Release Config errors 0
Details
pycicle daint-gcc-7.3.0-cuda-9.2.148_3.19-6.0.7.1_2.1__g3d9acc8-boost-1.68.0-c++11-Release Config errors 0
Details

@msimberg msimberg deleted the PAGE_SIZE_appleclang branch Apr 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.