Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix callable vtable for GCC4.9 #3760

Merged
merged 1 commit into from Apr 1, 2019

Conversation

Projects
None yet
3 participants
@K-ballo
Copy link
Member

commented Mar 30, 2019

Workaround for GCC regression when forming function pointers to [[noreturn]] functions in constant expressions

Workaround for GCC regression when forming function pointers to [[nor…
…eturn]] functions in constant expressions

@K-ballo K-ballo requested a review from msimberg Mar 30, 2019

@msimberg msimberg added this to the 1.3.0 milestone Mar 30, 2019

@msimberg
Copy link
Contributor

left a comment

Thanks @K-ballo!

@msimberg

This comment has been minimized.

Copy link
Contributor

commented Mar 30, 2019

For reference, this was a previously failing build with gcc 4.9, and this is after the fix.

@hkaiser
Copy link
Member

left a comment

LGTM, thanks!

@msimberg msimberg merged commit fa26059 into master Apr 1, 2019

11 of 16 checks passed

pycicle daint-clang-7.0-boost-1.68.0-c++17-nonetworking-Debug Test errors 7
Details
pycicle daint-gcc-7.3.0-boost-1.68.0-c++17-Release Build errors 11
Details
pycicle daint-gcc-7.3.0-boost-1.68.0-c++17-Release Test errors 2
Details
pycicle daint-gcc-7.3.0-cuda-9.2.148_3.19-6.0.7.1_2.1__g3d9acc8-boost-1.68.0-c++11-Release Build errors 48
Details
pycicle daint-gcc-7.3.0-cuda-9.2.148_3.19-6.0.7.1_2.1__g3d9acc8-boost-1.68.0-c++11-Release Test errors 8
Details
build-and-test Workflow: build-and-test
Details
pycicle daint-clang-3.8-boost-1.58.0-c++11-Release Build errors 0
Details
pycicle daint-clang-3.8-boost-1.58.0-c++11-Release Config errors 0
Details
pycicle daint-clang-3.8-boost-1.58.0-c++11-Release Test errors 0
Details
pycicle daint-clang-7.0-boost-1.68.0-c++17-nonetworking-Debug Build errors 0
Details
pycicle daint-clang-7.0-boost-1.68.0-c++17-nonetworking-Debug Config errors 0
Details
pycicle daint-gcc-4.9.3-boost-1.58.0-c++11-Debug Build errors 0
Details
pycicle daint-gcc-4.9.3-boost-1.58.0-c++11-Debug Config errors 0
Details
pycicle daint-gcc-4.9.3-boost-1.58.0-c++11-Debug Test errors 0
Details
pycicle daint-gcc-7.3.0-boost-1.68.0-c++17-Release Config errors 0
Details
pycicle daint-gcc-7.3.0-cuda-9.2.148_3.19-6.0.7.1_2.1__g3d9acc8-boost-1.68.0-c++11-Release Config errors 0
Details

@msimberg msimberg deleted the gcc49-noreturn-workaround branch Apr 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.