Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump minimal boost supported version to 1.61.0 #3787

Closed
wants to merge 1 commit into from
Closed

Bump minimal boost supported version to 1.61.0 #3787

wants to merge 1 commit into from

Conversation

K-ballo
Copy link
Member

@K-ballo K-ballo commented Apr 10, 2019

No description provided.

@hkaiser hkaiser added this to the 1.3.0 milestone Apr 11, 2019
hkaiser
hkaiser reviewed Apr 11, 2019
View reviewed changes
hpx/config.hpp
@@ -33,9 +33,9 @@

#include <boost/version.hpp>

#if BOOST_VERSION < 105800
#if BOOST_VERSION < 106100
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we bail out or should we just warn, it might work after all.

@msimberg
Copy link
Contributor

@K-ballo this is nearly the same as #3786 ;) But I see you've been more proactive in bumping recommended version numbers and some other changes. I'll move those changes over to the other branch. Would you mind checking if there's some difference you don't agree with?

@K-ballo
Copy link
Member Author

K-ballo commented Apr 11, 2019

@K-ballo this is nearly the same as #3786 ;)

I hadn't noticed that other PR. This was on an old branch, waiting for the release of Boost 1.70.0.

@K-ballo K-ballo closed this Apr 11, 2019
@K-ballo K-ballo deleted the boost-bump branch April 11, 2019 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaiser hkaiser hkaiser left review comments

Assignees
No one assigned
Labels
category: CMake type: compatibility issue
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@K-ballo @msimberg @hkaiser