Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hpxcxx to look at lib64 and use python3 #3803

Merged
merged 7 commits into from Apr 26, 2019

Conversation

@stevenrbrandt
Copy link
Member

commented Apr 17, 2019

Fixes issues using hpxcxx on the singularity image

Proposed Changes

  • check explicitly for the hpx_application.pc file
  • use python3
  • check lib64 in addition to lib

Any background context you want to provide?

@stevenrbrandt stevenrbrandt requested a review from hkaiser Apr 17, 2019

@stevenrbrandt

This comment has been minimized.

Copy link
Member Author

commented Apr 22, 2019

@hkaiser it never limited things to Python v3, but it no longer matters because it now uses @PYTHON_EXECUTABLE@.

@hkaiser
Copy link
Member

left a comment

LGTM, thanks!

@msimberg

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

Is it a must to use the exact path of the Python executable? This means that the path will be system specific, which can be annoying for cross-compilation. Not a huge deal, but if it's not necessary I'd rather not hardcode it like that.

@hkaiser

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

#3718 was asking for exactly this. I'm not sure what's the best way out...

@msimberg
Copy link
Contributor

left a comment

Thinking about this a bit more a user should be able to set PYTHON_EXECUTABLE to /usr/bin/env python and get back the same behaviour as before if they need it. hpxrun and hpxcxx are also the only Python scripts that we actually install, so that should be enough (I don't think we need to do this for other Python scripts in the repo, at least now). Sorry for the fuss, this looks good.

@msimberg msimberg added this to the 1.3.0 milestone Apr 26, 2019

@msimberg msimberg merged commit 6ef1d53 into master Apr 26, 2019

1 check passed

build-and-test Workflow: build-and-test
Details

@msimberg msimberg deleted the update-hpxcxx branch Apr 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.