Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting default scheduler mode via the configuration database #3814

Merged
merged 3 commits into from May 2, 2019

Conversation

@hkaiser
Copy link
Member

commented Apr 21, 2019

No description provided.

@hkaiser hkaiser force-pushed the configure_scheduler_mode branch from d9845c8 to a4c7886 Apr 21, 2019

{
mode = scheduler_mode(hpx::util::safe_lexical_cast<std::size_t>(
default_scheduler_mode));
HPX_ASSERT((mode & ~scheduler_mode::all_flags) == 0);

This comment has been minimized.

Copy link
@msimberg

msimberg Apr 23, 2019

Contributor

A message would probably be good here saying that the config entry contains illegal scheduler options.

This comment has been minimized.

Copy link
@hkaiser

hkaiser Apr 23, 2019

Author Member

Yah, I was thinking of throwing an exception, I might just do that instead.

This comment has been minimized.

Copy link
@msimberg

msimberg Apr 23, 2019

Contributor

Yeah, that works. I was thinking of HPX_ASSERT_MSG but either is fine with me.

@msimberg

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

@hkaiser just added a short message to the assertion. I suppose you're done with this otherwise? We can merge if the build succeeds.

@hkaiser

This comment has been minimized.

Copy link
Member Author

commented May 2, 2019

@hkaiser just added a short message to the assertion. I suppose you're done with this otherwise? We can merge if the build succeeds.

Yah looks good, sorry - didn't have time to look into this.

{
f.get(); // rethrow exceptions
}

This comment has been minimized.

Copy link
@msimberg

msimberg May 2, 2019

Contributor

I think this officially exposes the brokenness of our NUMA handling(?) on CircleCI (https://circleci.com/gh/STEllAR-GROUP/hpx/86317). #3802 also had problems with this. We might just have to disable or remove this example and leave it to @biddisco to replace this numa_allocator with his new and improved one ;)

@msimberg msimberg merged commit 26e656f into master May 2, 2019

8 of 10 checks passed

build-and-test Workflow: build-and-test
Details
pycicle daint-gcc-5.5.0-boost-1.61.0-c++11-Debug-generic-context Test errors 1
Details
pycicle daint-clang-4.0-boost-1.61.0-c++11-Release-dynamic-bitset Build errors 0
Details
pycicle daint-clang-4.0-boost-1.61.0-c++11-Release-dynamic-bitset Config errors 0
Details
pycicle daint-clang-4.0-boost-1.61.0-c++11-Release-dynamic-bitset Test errors 0
Details
pycicle daint-clang-8.0-boost-1.69.0-c++17-Debug Build errors 0
Details
pycicle daint-clang-8.0-boost-1.69.0-c++17-Debug Config errors 0
Details
pycicle daint-clang-8.0-boost-1.69.0-c++17-Debug Test errors 0
Details
pycicle daint-gcc-5.5.0-boost-1.61.0-c++11-Debug-generic-context Build errors 0
Details
pycicle daint-gcc-5.5.0-boost-1.61.0-c++11-Debug-generic-context Config errors 0
Details

@msimberg msimberg deleted the configure_scheduler_mode branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.