Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable transpose_block_numa example on CircleCI #3834

Merged

Conversation

Projects
None yet
3 participants
@msimberg
Copy link
Contributor

commented May 3, 2019

Any background context you want to provide?

This call to hwloc:

#if HWLOC_API_VERSION >= 0x00010b06
hwloc_get_area_membind(topo, reinterpret_cast<void const*>(lva),
1, nodeset, &policy, HWLOC_MEMBIND_BYNODESET);
#else
hwloc_get_area_membind_nodeset(topo,
reinterpret_cast<void const*>(lva), 1, nodeset, &policy, 0);
#endif
returns -1 and sets errno = EPERM (i.e. permission denied) on CircleCI. My guess is that this hasn't come up before because of recent changes to exception handling (#3662, #3814), or CircleCI launching containers differently. Since we have pycicle running as well without containers I think we can safely disable the example on CircleCI.

@hkaiser

hkaiser approved these changes May 3, 2019

Copy link
Member

left a comment

LGTM, thanks!

@biddisco

This comment has been minimized.

Copy link
Contributor

commented May 3, 2019

Would it be a good idea to add some kind of cmake check that detects if we are inside a docker container and then we can disable certain tests in a more formal way
https://stackoverflow.com/questions/20010199/how-to-determine-if-a-process-runs-inside-lxc-docker
(That is assuming the build and test happen in the same container)

@hkaiser

This comment has been minimized.

Copy link
Member

commented May 3, 2019

Would it be a good idea to add some kind of cmake check that detects if we are inside a docker container and then we can disable certain tests in a more formal way

Let's do this. I'd suggest to leave it for a later PR, though as it needs more investigation. I think we should go ahead and merge this PR now as a stopgap measure.

@hkaiser hkaiser merged commit 1d96640 into STEllAR-GROUP:master May 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.