Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compile flags and definitions to modules #3858

Merged

Conversation

Projects
None yet
2 participants
@msimberg
Copy link
Contributor

commented May 14, 2019

Not critical for 1.3.0 (since the preprocessor module only creates a dummy static library), but should be merged soon after.

@hkaiser
Copy link
Member

left a comment

LGTM, thanks!

@msimberg msimberg modified the milestones: 1.4.0, 1.3.0 May 15, 2019

@msimberg msimberg merged commit 1014bf4 into STEllAR-GROUP:master May 15, 2019

12 of 14 checks passed

Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
pycicle daint-gcc-8.3.0-boost-1.69.0-c++17-Debug-nonetworking Test errors 3
Details
build-and-test Workflow: build-and-test
Details
pycicle daint-clang-4.0-boost-1.61.0-c++11-Release-dynamic-bitset Build errors 0
Details
pycicle daint-clang-4.0-boost-1.61.0-c++11-Release-dynamic-bitset Config errors 0
Details
pycicle daint-clang-4.0-boost-1.61.0-c++11-Release-dynamic-bitset Test errors 0
Details
pycicle daint-clang-8.0-boost-1.69.0-c++17-Debug Build errors 0
Details
pycicle daint-clang-8.0-boost-1.69.0-c++17-Debug Config errors 0
Details
pycicle daint-clang-8.0-boost-1.69.0-c++17-Debug Test errors 0
Details
pycicle daint-gcc-5.5.0-boost-1.61.0-c++11-Debug-generic-context Build errors 0
Details
pycicle daint-gcc-5.5.0-boost-1.61.0-c++11-Debug-generic-context Config errors 0
Details
pycicle daint-gcc-5.5.0-boost-1.61.0-c++11-Debug-generic-context Test errors 0
Details
pycicle daint-gcc-8.3.0-boost-1.69.0-c++17-Debug-nonetworking Build errors 0
Details
pycicle daint-gcc-8.3.0-boost-1.69.0-c++17-Debug-nonetworking Config errors 0
Details

@msimberg msimberg deleted the msimberg:modules-compile-flags-definitions branch May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.