Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old compatibility bases from make_action #3899

Merged
merged 3 commits into from Aug 2, 2019
Merged

Remove old compatibility bases from make_action #3899

merged 3 commits into from Aug 2, 2019

Conversation

K-ballo
Copy link
Member

@K-ballo K-ballo commented Jun 9, 2019

No description provided.

hkaiser
hkaiser reviewed Jun 9, 2019
View reviewed changes
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should now be able to remove the specialization of the extract_action trait as well.

@K-ballo
Copy link
Member Author

K-ballo commented Jun 9, 2019

We should now be able to remove the specialization of the extract_action trait as well.

Was that specialization there only for handling cases of extract_action<make_action<...>>?

@hkaiser hkaiser added this to the 1.4.0 milestone Jun 9, 2019
@hkaiser
Copy link
Member

hkaiser commented Jun 10, 2019

@K-ballo looks like I was wrong when I said we can remove the extract_action trait (https://circleci.com/gh/STEllAR-GROUP/hpx/94660)

@K-ballo
Copy link
Member Author

K-ballo commented Jun 11, 2019

@K-ballo looks like I was wrong when I said we can remove the extract_action trait (https://circleci.com/gh/STEllAR-GROUP/hpx/94660)

Those actually break with just the base change too.

We'll have to start with only deprecating those bases, fixing the examples, and tightening extract_action to specialize only for the make_action traits.

@hkaiser
Copy link
Member

hkaiser commented Jun 12, 2019

Those actually break with just the base change too.

Not sure about this...

We'll have to start with only deprecating those bases, fixing the examples, and tightening extract_action to specialize only for the make_action traits.

I fully agree. Let's do it in stages.

K-ballo and others added 3 commits July 26, 2019 10:12
@K-ballo @hkaiser
Remove old compatibility bases from make_action
75489f3
@K-ballo @hkaiser
Remove extract_action specialization for make_action
2f82971
@hkaiser
Making optional removing action bases
65566e1 
- introduce HPX_WITH_ACTION_BASE_COMPATIBILITY option (ON by default)
- fixed all uses of make_action<> in code base
@hkaiser
Copy link
Member

hkaiser commented Jul 31, 2019

@msimberg I think this is good to go. Please review and/or merge at your leasure.

msimberg
msimberg approved these changes Aug 2, 2019
View reviewed changes
Copy link
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@msimberg msimberg merged commit 966745e into STEllAR-GROUP:master Aug 2, 2019
@K-ballo K-ballo deleted the remove-action-bases branch August 2, 2019 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaiser hkaiser hkaiser left review comments

@msimberg msimberg msimberg approved these changes

Assignees
No one assigned
Labels
category: actions type: compatibility issue
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@K-ballo @hkaiser @msimberg