Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making sure C++ standard is properly detected and propagated #4108

Merged
merged 2 commits into from Sep 27, 2019

Conversation

@hkaiser
Copy link
Member

commented Sep 25, 2019

  • enable C++17 features only if available and compilation mode is C++17 (__cplusplus >= 201500), same for C++14 (__cplusplus >= 201402)
  • making sure MSVC actually generates proper __cplusplus preprocessor constant
  • flyby: fix CMakeLists.txt to properly detect MSVC versions
@hkaiser hkaiser added this to the 1.4.0 milestone Sep 25, 2019
@hkaiser hkaiser force-pushed the fixing_cxx_standard branch from af3db23 to 19e594d Sep 25, 2019
@hkaiser hkaiser changed the title Making sure C++ standard is properly detected and p[ropagated Making sure C++ standard is properly detected and propagated Sep 25, 2019
- enable C++17 features only if available and compilation mode is C++17 (__cplusplus >= 201500), same for C++14
- making sure MSVC actually generates proper __cplusplus preprocessor constant
- flyby: fix CMakeLists.txt to properly detect MSVC versions
@hkaiser hkaiser force-pushed the fixing_cxx_standard branch from 19e594d to e388c81 Sep 25, 2019
Copy link
Member

left a comment

LGTM, thanks!

@hkaiser hkaiser merged commit 6a6d748 into master Sep 27, 2019
15 of 17 checks passed
15 of 17 checks passed
pycicle daint-gcc-cuda Test errors 1
Details
pycicle daint-gcc-newest Test errors 1
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pycicle daint-clang-newest Build errors 0
Details
pycicle daint-clang-newest Config errors 0
Details
pycicle daint-clang-newest Test errors 0
Details
pycicle daint-clang-oldest Build errors 0
Details
pycicle daint-clang-oldest Config errors 0
Details
pycicle daint-clang-oldest Test errors 0
Details
pycicle daint-gcc-cuda Build errors 0
Details
pycicle daint-gcc-cuda Config errors 0
Details
pycicle daint-gcc-newest Build errors 0
Details
pycicle daint-gcc-newest Config errors 0
Details
pycicle daint-gcc-oldest Build errors 0
Details
pycicle daint-gcc-oldest Config errors 0
Details
pycicle daint-gcc-oldest Test errors 0
Details
@hkaiser hkaiser deleted the fixing_cxx_standard branch Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.