Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stackless coroutines now can refer to themselves (through get_self() and friends) #4156

Merged
merged 1 commit into from Oct 31, 2019

Conversation

@hkaiser
Copy link
Member

hkaiser commented Oct 24, 2019

Fixes #4155

@hkaiser

This comment has been minimized.

Copy link
Member Author

hkaiser commented Oct 24, 2019

@tianyi93 this should resolve your issues with stackless threads you were seeing in hpxMP. Please verify.

@hkaiser hkaiser force-pushed the fixing_4155 branch from cc9f226 to 20de9fc Oct 24, 2019
@tianyi93

This comment has been minimized.

Copy link
Member

tianyi93 commented Oct 24, 2019

@hkaiser It seems error: 'hpx/coroutines/detail/coroutine_stackless_self.hpp' file not found is missing

@hkaiser hkaiser force-pushed the fixing_4155 branch from 20de9fc to 18a6f7a Oct 24, 2019
@tianyi93

This comment has been minimized.

Copy link
Member

tianyi93 commented Oct 25, 2019

@hkaiser SIGSEGV is happening when executing create_thread function under hpx/runtime/threads/detail/create_thread.hpp

@hkaiser hkaiser force-pushed the fixing_4155 branch from 18a6f7a to 3b36304 Oct 25, 2019
…and friends)
@hkaiser hkaiser force-pushed the fixing_4155 branch from 3b36304 to 541f336 Oct 25, 2019
Copy link
Contributor

msimberg left a comment

Thanks!

@msimberg

This comment has been minimized.

Copy link
Contributor

msimberg commented Oct 30, 2019

@tianyi93 I guess your problem has already been fixed by @hkaiser? Not sure if the problem showed up on our builders in the first place but they are happy (enough) now.

@tianyi93

This comment has been minimized.

Copy link
Member

tianyi93 commented Oct 30, 2019

@msimberg Yes, the compiler error has been fixed. The issue remains is the implementation in the hpxMP side now. Thanks!

@msimberg msimberg merged commit 651f701 into master Oct 31, 2019
16 of 19 checks passed
16 of 19 checks passed
pycicle daint-clang-oldest Test errors 1
Details
pycicle daint-gcc-cuda Test errors 2
Details
pycicle daint-gcc-oldest Test errors 1
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
build-and-test Workflow: build-and-test
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pycicle daint-clang-newest Build errors 0
Details
pycicle daint-clang-newest Config errors 0
Details
pycicle daint-clang-newest Test errors 0
Details
pycicle daint-clang-oldest Build errors 0
Details
pycicle daint-clang-oldest Config errors 0
Details
pycicle daint-gcc-cuda Build errors 0
Details
pycicle daint-gcc-cuda Config errors 0
Details
pycicle daint-gcc-newest Build errors 0
Details
pycicle daint-gcc-newest Config errors 0
Details
pycicle daint-gcc-newest Test errors 0
Details
pycicle daint-gcc-oldest Build errors 0
Details
pycicle daint-gcc-oldest Config errors 0
Details
@msimberg msimberg deleted the fixing_4155 branch Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.