Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using target_link_libraries for cmake versions >= 3.12 #4160

Merged
merged 1 commit into from Oct 31, 2019

Conversation

@hkaiser
Copy link
Member

hkaiser commented Oct 25, 2019

Fixes linker problems in Phylanx on Windows

cmake/HPX_SetupMPI.cmake Outdated Show resolved Hide resolved
cmake/templates/HPXMacros.cmake.in Outdated Show resolved Hide resolved
@hkaiser hkaiser force-pushed the target_link_libraries branch 2 times, most recently from 9020d01 to 71f7841 Oct 26, 2019
@aurianer

This comment has been minimized.

Copy link
Contributor

aurianer commented Oct 29, 2019

Should we also do the same for other imported libraries like hpx::valgrind or else ? I can do it if it bothers you btw ^^

@aurianer

This comment has been minimized.

Copy link
Contributor

aurianer commented Oct 29, 2019

Otherwise LGTM ! thanks!

@hkaiser

This comment has been minimized.

Copy link
Member Author

hkaiser commented Oct 29, 2019

Should we also do the same for other imported libraries like hpx::valgrind or else ? I can do it if it bothers you btw ^^

@aurianer I have not touched those as I'm not able to test things on non-windows platforms easily.

@aurianer

This comment has been minimized.

Copy link
Contributor

aurianer commented Oct 30, 2019

Ok no pb, I'll do it later!

@hkaiser hkaiser force-pushed the target_link_libraries branch from 71f7841 to fc6e6c9 Oct 30, 2019
@hkaiser hkaiser force-pushed the target_link_libraries branch from fc6e6c9 to cbeb3cd Oct 30, 2019
@msimberg msimberg requested a review from aurianer Oct 31, 2019
@hkaiser

This comment has been minimized.

Copy link
Member Author

hkaiser commented Oct 31, 2019

@msimberg could we merge this, please? This fix is crucial for us in order to make dependent projects compile properly on multi-built-type CMake systems (Visual Studio).

@hkaiser hkaiser merged commit 81fd79b into master Oct 31, 2019
12 of 13 checks passed
12 of 13 checks passed
pycicle daint-gcc-cuda Test errors 1
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
build-and-test Workflow: build-and-test
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pycicle daint-gcc-cuda Build errors 0
Details
pycicle daint-gcc-cuda Config errors 0
Details
pycicle daint-gcc-newest Build errors 0
Details
pycicle daint-gcc-newest Config errors 0
Details
pycicle daint-gcc-newest Test errors 0
Details
pycicle daint-gcc-oldest Build errors 0
Details
pycicle daint-gcc-oldest Config errors 0
Details
pycicle daint-gcc-oldest Test errors 0
Details
@hkaiser hkaiser deleted the target_link_libraries branch Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.