Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignoring lock in all_to_all and all_reduce #4255

Merged
merged 1 commit into from Dec 3, 2019

Conversation

@folshost
Copy link
Contributor

folshost commented Dec 2, 2019

Fixes #

Proposed Changes

  • Adding lock ignore to all_reduce and all_to_all

Any background context you want to provide?

Related to a Phylanx issue encountered when trying to add matrices with Blaze. When the matrix size exceeded the Blaze parallelization threshold, the presence of the lock in all_reduce caused hpx to throw when suspension was attempted during the parallel add

@hkaiser
hkaiser approved these changes Dec 3, 2019
Copy link
Member

hkaiser left a comment

LGTM, thanks!

@hkaiser

This comment has been minimized.

Copy link
Member

hkaiser commented Dec 3, 2019

The remaining failure is unrelated.

@msimberg msimberg merged commit d802940 into STEllAR-GROUP:master Dec 3, 2019
15 of 18 checks passed
15 of 18 checks passed
build-and-test Workflow: build-and-test
Details
pycicle daint-clang-apex Test errors 1
Details
pycicle daint-cray-clang-cuda Test errors 1
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pycicle daint-clang-apex Build errors 0
Details
pycicle daint-clang-apex Config errors 0
Details
pycicle daint-clang-oldest Build errors 0
Details
pycicle daint-clang-oldest Config errors 0
Details
pycicle daint-clang-oldest Test errors 0
Details
pycicle daint-cray-clang-cuda Build errors 0
Details
pycicle daint-cray-clang-cuda Config errors 0
Details
pycicle daint-gcc-newest Build errors 0
Details
pycicle daint-gcc-newest Config errors 0
Details
pycicle daint-gcc-newest Test errors 0
Details
pycicle daint-gcc-oldest Build errors 0
Details
pycicle daint-gcc-oldest Config errors 0
Details
pycicle daint-gcc-oldest Test errors 0
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.