Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing HPX/APEX linking and dependencies for external projects like Phylanx #4261

Merged
merged 1 commit into from Dec 6, 2019

Conversation

@khuck
Copy link
Contributor

khuck commented Dec 4, 2019

Fixes linking problems with external executables. Fixes flatbed problems from apex dependencies.

@khuck khuck requested a review from msimberg Dec 4, 2019
@khuck

This comment has been minimized.

Copy link
Contributor Author

khuck commented Dec 4, 2019

The build-and-test CI failure has to do with documentation, I have no idea why that failed or whether it's relevant

@hkaiser

This comment has been minimized.

Copy link
Member

hkaiser commented Dec 5, 2019

The build-and-test CI failure has to do with documentation, I have no idea why that failed or whether it's relevant

Yes, Auriane is currently working on fixing this (see also #4260).

@hkaiser hkaiser added this to the 1.4.0 milestone Dec 5, 2019
@hkaiser hkaiser changed the title Fixing HPX/APEX linking and dependencies for external projects like P… Fixing HPX/APEX linking and dependencies for external projects like Phylanx Dec 5, 2019
Copy link
Contributor

msimberg left a comment

Thanks!

@msimberg

This comment has been minimized.

Copy link
Contributor

msimberg commented Dec 5, 2019

The pycicle builder seems to agree with this as well, which is good. It does not test that APEX actually works though (and we should try to think of a more thorough test for this; perhaps grepping stdout and otf2 files for keywords like correct task names etc.). @khuck I take it you checked that this works with e.g. Phylanx? Also, did you end up not needing to change anything related to rpath handling?

@hkaiser
hkaiser approved these changes Dec 5, 2019
Copy link
Member

hkaiser left a comment

LGTM, thanks!

@khuck

This comment has been minimized.

Copy link
Contributor Author

khuck commented Dec 5, 2019

The pycicle builder seems to agree with this as well, which is good. It does not test that APEX actually works though (and we should try to think of a more thorough test for this; perhaps grepping stdout and otf2 files for keywords like correct task names etc.). @khuck I take it you checked that this works with e.g. Phylanx? Also, did you end up not needing to change anything related to rpath handling?

Correct, the rpath handling is now fixed. For testing, there is a tests/unit/apex directory, so running ctest -R tests.unit.apex should check whether the build was valid. Although the only way to really test this change is to use HPX with another project, which is the Phylanx test. I have a buildbot server that does just that, http://omega.nic.uoregon.edu:8020

@msimberg msimberg merged commit 8732913 into master Dec 6, 2019
23 of 25 checks passed
23 of 25 checks passed
build-and-test Workflow: build-and-test
Details
pycicle daint-clang-apex Test errors 1
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pycicle daint-clang-apex Build errors 0
Details
pycicle daint-clang-apex Config errors 0
Details
pycicle daint-clang-newest Build errors 0
Details
pycicle daint-clang-newest Config errors 0
Details
pycicle daint-clang-newest Test errors 0
Details
pycicle daint-clang-oldest Build errors 0
Details
pycicle daint-clang-oldest Config errors 0
Details
pycicle daint-clang-oldest Test errors 0
Details
pycicle daint-cray-clang-cuda Build errors 0
Details
pycicle daint-cray-clang-cuda Config errors 0
Details
pycicle daint-cray-clang-cuda Test errors 0
Details
pycicle daint-gcc-cuda Build errors 0
Details
pycicle daint-gcc-cuda Config errors 0
Details
pycicle daint-gcc-cuda Test errors 0
Details
pycicle daint-gcc-newest Build errors 0
Details
pycicle daint-gcc-newest Config errors 0
Details
pycicle daint-gcc-newest Test errors 0
Details
pycicle daint-gcc-oldest Build errors 0
Details
pycicle daint-gcc-oldest Config errors 0
Details
pycicle daint-gcc-oldest Test errors 0
Details
@msimberg msimberg deleted the apex-linking branch Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.