Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure APEX is linked to even when not explicitly referenced #4275

Merged
merged 1 commit into from Dec 16, 2019

Conversation

msimberg
Copy link
Contributor

@msimberg msimberg commented Dec 13, 2019

Fixes #4273.

@msimberg
Copy link
Contributor Author

@msimberg msimberg commented Dec 13, 2019

@kordejong would you mind giving this a try? I couldn't make CMake apply the flag only to apex. This adds -Wl,-no-as-needed to all dependent libraries which may result in other non-references libraries being linked as well, but at least apex gets linked.

@kordejong
Copy link
Contributor

@kordejong kordejong commented Dec 13, 2019

I think you lost a dash in front of no-as-needed. After I put it in, the build continued. It is still busy, but I noticed that fibonacci and some other examples I checked are linked to apex.

@msimberg
Copy link
Contributor Author

@msimberg msimberg commented Dec 13, 2019

Very good catch, thanks! I did indeed lose one. I've added it now.

@kordejong
Copy link
Contributor

@kordejong kordejong commented Dec 13, 2019

The build finished fine, so I think your PR is good.

@msimberg msimberg merged commit bbc3ad7 into master Dec 16, 2019
24 of 25 checks passed
@msimberg msimberg deleted the msimberg-patch-2 branch Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants