Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure APEX is linked to even when not explicitly referenced #4275

Merged
merged 1 commit into from Dec 16, 2019

Conversation

@msimberg
Copy link
Contributor

msimberg commented Dec 13, 2019

Fixes #4273.

@msimberg

This comment has been minimized.

Copy link
Contributor Author

msimberg commented Dec 13, 2019

@kordejong would you mind giving this a try? I couldn't make CMake apply the flag only to apex. This adds -Wl,-no-as-needed to all dependent libraries which may result in other non-references libraries being linked as well, but at least apex gets linked.

@kordejong

This comment has been minimized.

Copy link
Contributor

kordejong commented Dec 13, 2019

I think you lost a dash in front of no-as-needed. After I put it in, the build continued. It is still busy, but I noticed that fibonacci and some other examples I checked are linked to apex.

@msimberg msimberg force-pushed the msimberg-patch-2 branch from 53954e7 to e8f5a1f Dec 13, 2019
@msimberg

This comment has been minimized.

Copy link
Contributor Author

msimberg commented Dec 13, 2019

Very good catch, thanks! I did indeed lose one. I've added it now.

@kordejong

This comment has been minimized.

Copy link
Contributor

kordejong commented Dec 13, 2019

The build finished fine, so I think your PR is good.

@msimberg msimberg merged commit bbc3ad7 into master Dec 16, 2019
24 of 25 checks passed
24 of 25 checks passed
pycicle daint-clang-apex Test errors 1
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
build-and-test Workflow: build-and-test
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
pycicle daint-clang-apex Build errors 0
Details
pycicle daint-clang-apex Config errors 0
Details
pycicle daint-clang-newest Build errors 0
Details
pycicle daint-clang-newest Config errors 0
Details
pycicle daint-clang-newest Test errors 0
Details
pycicle daint-clang-oldest Build errors 0
Details
pycicle daint-clang-oldest Config errors 0
Details
pycicle daint-clang-oldest Test errors 0
Details
pycicle daint-cray-clang-cuda Build errors 0
Details
pycicle daint-cray-clang-cuda Config errors 0
Details
pycicle daint-cray-clang-cuda Test errors 0
Details
pycicle daint-gcc-cuda Build errors 0
Details
pycicle daint-gcc-cuda Config errors 0
Details
pycicle daint-gcc-cuda Test errors 0
Details
pycicle daint-gcc-newest Build errors 0
Details
pycicle daint-gcc-newest Config errors 0
Details
pycicle daint-gcc-newest Test errors 0
Details
pycicle daint-gcc-oldest Build errors 0
Details
pycicle daint-gcc-oldest Config errors 0
Details
pycicle daint-gcc-oldest Test errors 0
Details
@msimberg msimberg deleted the msimberg-patch-2 branch Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.