-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding overload for hpx::init
/hpx::start
for use with resource partitioner
#4374
Conversation
Thanks @hkaiser for starting this. @aurianer has another PR almost ready to go which actually passes a callback to |
Thanks @msimberg. This change is to avoid a linker error on Windows under certain circumstances. The problem I'm trying to solve is that in cases were the resource-manager is initialized explicitly (with an explicit HPX-main function) the no-argument overload of This PR also makes passing the resource-partitioner to the runtime explicit. I never liked the implicit 'pseudo-global' resource partitioner that was snug in behind the scenes. I have no issue to achieve the two goals in any different way, however. |
…rtitioner - this helps resolving linker errors on Windows if the main entry point to HPX is in a shared library - this also cleans up the API as it makes the use of the resource partitioner explicit Note that this is a breaking API as the use of the no-argument versions of `init` and `start` is now deprecated when using an explicit resource partitioner.
cb6abb5
to
3111219
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks ! |
I already forgot about the test when I merged this. Let's figure out a test on IRC. |
Note that this is a breaking API as the use of the no-argument versions of
init
andstart
is now deprecated when using an explicit resource partitioner.