-
-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding C++20 counting semaphore API #4634
Conversation
5ca9e67
to
1248d7f
Compare
1248d7f
to
89532c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Same questions as for the barrier PR though. We (I) need to go through the doxygen docs anyway before the next release so we can skip that part now as well.
89532c6
to
e1a0fab
Compare
Yes, I'd say that's the plan in the end. But if we decide to skip splitting up the main library for 1.5.0 then we could still already have them in the include module. Either way. All I would like is that the headers from #4626 that we can put in place we do put in place for 1.5.0. It doesn't matter too much which module they are in before the main library is split into three. |
e1a0fab
to
a2e1d58
Compare
This should be good to go now as well. |
- adding hpx::binary_semaphore - adding hpx/counting_semaphore.hpp that imports it into namespace hpx - flyby: adding hpx/condition_variable.hpp and hpx/stop_token.hpp headers for conformance. This also imports lcos::local::conditional_variable into namespace hpx
a2e1d58
to
7f6b312
Compare
hpx::binary_semaphore
hpx/counting_semaphore.hpp
that imports it into namespace hpxhpx/condition_variable.hpp
andhpx/stop_token.hpp
headers forconformance. This also imports
lcos::local::conditional_variable
into namespace hpx