Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding C++20 counting semaphore API #4634

Merged
merged 1 commit into from
May 20, 2020
Merged

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented May 17, 2020

  • adding hpx::binary_semaphore
  • adding hpx/counting_semaphore.hpp that imports it into namespace hpx
  • flyby: adding hpx/condition_variable.hpp and hpx/stop_token.hpp headers for
    conformance. This also imports lcos::local::conditional_variable
    into namespace hpx

msimberg
msimberg previously approved these changes May 18, 2020
Copy link
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Same questions as for the barrier PR though. We (I) need to go through the doxygen docs anyway before the next release so we can skip that part now as well.

@msimberg
Copy link
Contributor

@hkaiser I summarized our API discussion from yesterday in #4329. Should we already go ahead and collect the "API headers" into the include module in this PR (and #4636, #4635)? I can also collect them afterwards while doing all the other headers.

@hkaiser
Copy link
Member Author

hkaiser commented May 19, 2020

Should we already go ahead and collect the "API headers" into the include module in this PR (and #4636, #4635)?

I thought we will create at least 3 include modules, one for each of the planned configurations. Should we go ahead and make that split now?

@msimberg
Copy link
Contributor

Should we already go ahead and collect the "API headers" into the include module in this PR (and #4636, #4635)?

I thought we will create at least 3 include modules, one for each of the planned configurations. Should we go ahead and make that split now?

Yes, I'd say that's the plan in the end. But if we decide to skip splitting up the main library for 1.5.0 then we could still already have them in the include module. Either way. All I would like is that the headers from #4626 that we can put in place we do put in place for 1.5.0. It doesn't matter too much which module they are in before the main library is split into three.

@hkaiser hkaiser force-pushed the cpp20_counting_semaphore branch from e1a0fab to a2e1d58 Compare May 19, 2020 16:19
@hkaiser
Copy link
Member Author

hkaiser commented May 19, 2020

This should be good to go now as well.

- adding hpx::binary_semaphore
- adding hpx/counting_semaphore.hpp that imports it into namespace hpx
- flyby: adding hpx/condition_variable.hpp and hpx/stop_token.hpp headers for
         conformance. This also imports lcos::local::conditional_variable
         into namespace hpx
@msimberg msimberg force-pushed the cpp20_counting_semaphore branch from a2e1d58 to 7f6b312 Compare May 20, 2020 08:41
@msimberg
Copy link
Contributor

Thanks @hkaiser. I just rebased this because of a conflict with #4634 in the CMake files. I'll merge this as soon as some of the GH actions builders come back clean.

@msimberg msimberg merged commit 2b23b15 into master May 20, 2020
@msimberg msimberg deleted the cpp20_counting_semaphore branch May 20, 2020 13:05
@hkaiser hkaiser mentioned this pull request Feb 19, 2021
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants