Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update get_function_annotation.hpp #4651

Merged
merged 1 commit into from
May 21, 2020
Merged

Update get_function_annotation.hpp #4651

merged 1 commit into from
May 21, 2020

Conversation

khuck
Copy link
Contributor

@khuck khuck commented May 20, 2020 •
edited by hkaiser
Loading

Fixes #4650

Proposed Changes

  • return nullptr for anonymous tasks so that annotation can annotate them

@khuck
Copy link
Contributor Author

khuck commented May 21, 2020

Are the test failures related?

@hkaiser hkaiser added this to the 1.5.0 milestone May 21, 2020
hkaiser
hkaiser approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hkaiser
Copy link
Member

hkaiser commented May 21, 2020

In the end I have to take responsibility for the original change that caused this problem. I asked @biddisco to ensure some sensible fallback name is used. Thanks for figuring out what the problem was, @khuck!

@hkaiser
Copy link
Member

hkaiser commented May 21, 2020

Are the test failures related?

The test failures are unrelated. I'll merge this now.

@hkaiser hkaiser merged commit ff74f28 into master May 21, 2020
@hkaiser hkaiser deleted the khuck-patch-4650 branch May 21, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaiser hkaiser hkaiser approved these changes

@aurianer aurianer Awaiting requested review from aurianer

@biddisco biddisco Awaiting requested review from biddisco

@msimberg msimberg Awaiting requested review from msimberg

Assignees
No one assigned
Labels
category: APEX type: compatibility issue
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

thread descriptions are broken...again
2 participants
@khuck @hkaiser