Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename generated modules headers #4696

Merged
merged 13 commits into from Jun 4, 2020

Conversation

aurianer
Copy link
Contributor

@aurianer aurianer commented Jun 2, 2020

Fixes #4647

Rename the modules main headers from hpx/<modulename>.hpp to hpx/modules/<modulename>.hpp

Note: it's on top of #4689 only the last 5 commits matter for this PR

@aurianer aurianer added this to the 1.5.0 milestone Jun 2, 2020
@aurianer aurianer force-pushed the rename_generated_headers branch 3 times, most recently from 73155bf to 4f15926 Compare June 2, 2020 15:37
@hkaiser hkaiser added this to In Progress in HPX modularization via automation Jun 2, 2020
hkaiser
hkaiser previously approved these changes Jun 2, 2020
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this!

@aurianer aurianer force-pushed the rename_generated_headers branch 2 times, most recently from 250b2b7 to 91eeb4f Compare June 3, 2020 08:04
@aurianer
Copy link
Contributor Author

aurianer commented Jun 3, 2020

Sorry I forgot to adapt the inspect tool to the new assertion header, this should be good now :)

@msimberg
Copy link
Contributor

msimberg commented Jun 4, 2020

I'll merge this since the lint checks pass on CircleCI and the builds pass on GitHub actions and pycicle. I'm ignoring the spelling suggestions.

@msimberg msimberg merged commit 7aab5d1 into STEllAR-GROUP:master Jun 4, 2020
HPX modularization automation moved this from In Progress to Done Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Rename generated collective headers in modules
3 participants