New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename generated modules headers #4696
Merged
msimberg
merged 13 commits into
STEllAR-GROUP:master
from
aurianer:rename_generated_headers
Jun 4, 2020
Merged
Rename generated modules headers #4696
msimberg
merged 13 commits into
STEllAR-GROUP:master
from
aurianer:rename_generated_headers
Jun 4, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aurianer
force-pushed
the
rename_generated_headers
branch
3 times, most recently
from
June 2, 2020 15:37
73155bf
to
4f15926
Compare
hkaiser
previously approved these changes
Jun 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this!
aurianer
force-pushed
the
rename_generated_headers
branch
2 times, most recently
from
June 3, 2020 08:04
250b2b7
to
91eeb4f
Compare
Sorry I forgot to adapt the inspect tool to the new assertion header, this should be good now :) |
msimberg
reviewed
Jun 3, 2020
Except for hpx/config.hpp
aurianer
force-pushed
the
rename_generated_headers
branch
from
June 3, 2020 16:12
91eeb4f
to
7d8ac89
Compare
I'll merge this since the lint checks pass on CircleCI and the builds pass on GitHub actions and pycicle. I'm ignoring the spelling suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4647
Rename the modules main headers from
hpx/<modulename>.hpp
tohpx/modules/<modulename>.hpp
Note: it's on top of #4689 only the last 5 commits matter for this PR