Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create coverage reports and upload them to codecov.io #4748

Merged
merged 1 commit into from Jun 13, 2020

Conversation

haampie
Copy link
Contributor

@haampie haampie commented Jun 12, 2020

Now that STEllAR-GROUP/docker_build_env#25 is merged, this PR generates coverage reports and uploads them to codecov.io. I believe codecov will magically accept reports without any other config.

On my fork of hpx circle ci timed out, so we have to see here if it works.

@hkaiser
Copy link
Member

hkaiser commented Jun 12, 2020

codacy accepts coverage reports as well and we already let it crawl our code base. Might be a good idea to make it aware of the new coverage results as well.

@haampie
Copy link
Contributor Author

haampie commented Jun 13, 2020

Thanks, that sounds useful indeed.

Seems like circle ci is not triggered, maybe because this is a pull request opened from a fork?

@hkaiser
Copy link
Member

hkaiser commented Jun 13, 2020

Seems like circle ci is not triggered, maybe because this is a pull request opened from a fork?

Let's merge this, then. If something goes wrong we'll fix it.

@hkaiser hkaiser merged commit 7e92d85 into STEllAR-GROUP:master Jun 13, 2020
@hkaiser
Copy link
Member

hkaiser commented Jun 13, 2020

While there are unrelated problems, I'm at least seeing this:
https://app.circleci.com/pipelines/github/STEllAR-GROUP/hpx/4083/workflows/68e0fecc-c6b7-4b90-b86f-6e56b3b7525c/jobs/201680

@haampie Could you have a look, please?

@haampie
Copy link
Contributor Author

haampie commented Jun 13, 2020

Ah, sorry, it was not meant to be merged yet, I was just hoping that I could test CI by opening a pull request.

lcov seems to be a ridiculously slow tool for the job, probably we should use https://github.com/mozilla/grcov instead.

For now maybe best to revert the pr. I can test it more in my fork.

@hkaiser
Copy link
Member

hkaiser commented Jun 14, 2020

FWIW, it might be better to create a dedicated GitHub action for this (instead of adding it to the CircleCI builder).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants