Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foreach adapt #4809

Merged
merged 10 commits into from Jul 13, 2020
Merged

Foreach adapt #4809

merged 10 commits into from Jul 13, 2020

Conversation

@gonidelis
Copy link
Contributor

gonidelis commented Jul 7, 2020

Adapt for_each in order to support for the begin and end iterators to be of different type

@jenkins-cscs
Copy link
Collaborator

jenkins-cscs commented Jul 7, 2020

Can one of the admins verify this patch?

@gonidelis gonidelis force-pushed the gonidelis:foreach_adapt branch from c06cff2 to 5bc4717 Jul 7, 2020
gonidelis added 2 commits Jul 7, 2020
@gonidelis gonidelis force-pushed the gonidelis:foreach_adapt branch from 332f1b1 to 2d5e9a1 Jul 7, 2020
@gonidelis
Copy link
Contributor Author

gonidelis commented Jul 7, 2020

Should I use the is_sentinel_for trait too?

@msimberg
Copy link
Contributor

msimberg commented Jul 10, 2020

add to whitelist

@gonidelis
Copy link
Contributor Author

gonidelis commented Jul 11, 2020

Important Note: Please don't merge yet. Need to add a couple of doxygen comments.

@hkaiser Please tell me if HPX_CONCEPT_REQUIRES_ format is fine:

  • The requirements are all aligned
  • The && operator is separated with space
  • There is extra indentation for the second line of the "two-lines requirements"
  • clang-format off includes the template parameters declaration (when it includes just the HPX_CONCEPT_REQUIRES macro, clang-format messes up the alignment of clang-format off and clang-format on comments)
@gonidelis gonidelis force-pushed the gonidelis:foreach_adapt branch from 4137dc1 to c68d76c Jul 12, 2020
Copy link
Member

hkaiser left a comment

LGTM otherwise, thanks!

@gonidelis gonidelis force-pushed the gonidelis:foreach_adapt branch from c68d76c to f709563 Jul 12, 2020
@hkaiser hkaiser added this to Open Tickets in Standard Algorithms Jul 12, 2020
@hkaiser hkaiser moved this from Open Tickets to Work in progress in Standard Algorithms Jul 12, 2020
@hkaiser hkaiser merged commit 4016672 into STEllAR-GROUP:master Jul 13, 2020
21 of 26 checks passed
21 of 26 checks passed
build build
Details
build
Details
build
Details
build
Details
build
Details
build-and-test Workflow: build-and-test
Details
default Build finished.
Details
pycicle daint-clang-apex Test errors 4
Details
pycicle daint-gcc-cuda Test errors 1
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
pycicle daint-clang-apex Build errors 0
Details
pycicle daint-clang-apex Config errors 0
Details
pycicle daint-clang-newest Build errors 0
Details
pycicle daint-clang-newest Config errors 0
Details
pycicle daint-clang-newest Test errors 0
Details
pycicle daint-clang-oldest Build errors 0
Details
pycicle daint-clang-oldest Config errors 0
Details
pycicle daint-clang-oldest Test errors 0
Details
pycicle daint-cray-clang-cuda Build errors 0
Details
pycicle daint-cray-clang-cuda Config errors 0
Details
pycicle daint-cray-clang-cuda Test errors 0
Details
pycicle daint-gcc-cuda Build errors 0
Details
pycicle daint-gcc-cuda Config errors 0
Details
pycicle daint-gcc-newest Build errors 0
Details
pycicle daint-gcc-newest Config errors 0
Details
pycicle daint-gcc-newest Test errors 0
Details
Standard Algorithms automation moved this from Work in progress to Merged to master Jul 13, 2020
@hkaiser hkaiser added this to the 1.5.0 milestone Jul 13, 2020
@gonidelis gonidelis deleted the gonidelis:foreach_adapt branch Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Standard Algorithms
  
Merged to master
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.