Skip to content

Conversation

@gonidelis
Copy link
Contributor

Adapt for_each in order to support for the begin and end iterators to be of different type

@jenkins-cscs
Copy link

Can one of the admins verify this patch?

@gonidelis
Copy link
Contributor Author

Should I use the is_sentinel_for trait too?

@msimberg
Copy link
Contributor

add to whitelist

@gonidelis
Copy link
Contributor Author

gonidelis commented Jul 11, 2020

Important Note: Please don't merge yet. Need to add a couple of doxygen comments.

@hkaiser Please tell me if HPX_CONCEPT_REQUIRES_ format is fine:

  • The requirements are all aligned
  • The && operator is separated with space
  • There is extra indentation for the second line of the "two-lines requirements"
  • clang-format off includes the template parameters declaration (when it includes just the HPX_CONCEPT_REQUIRES macro, clang-format messes up the alignment of clang-format off and clang-format on comments)

hkaiser
hkaiser previously approved these changes Jul 12, 2020
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise, thanks!

@hkaiser hkaiser added this to the 1.5.0 milestone Jul 13, 2020
@gonidelis gonidelis deleted the foreach_adapt branch July 22, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants