Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foreach adapt #4809

merged 10 commits into from Jul 13, 2020

Foreach adapt #4809

merged 10 commits into from Jul 13, 2020


Copy link

@gonidelis gonidelis commented Jul 7, 2020

Adapt for_each in order to support for the begin and end iterators to be of different type

Copy link

jenkins-cscs commented Jul 7, 2020

Can one of the admins verify this patch?

Copy link
Contributor Author

gonidelis commented Jul 7, 2020

Should I use the is_sentinel_for trait too?

Copy link

msimberg commented Jul 10, 2020

add to whitelist

Copy link
Contributor Author

gonidelis commented Jul 11, 2020

Important Note: Please don't merge yet. Need to add a couple of doxygen comments.

@hkaiser Please tell me if HPX_CONCEPT_REQUIRES_ format is fine:

  • The requirements are all aligned
  • The && operator is separated with space
  • There is extra indentation for the second line of the "two-lines requirements"
  • clang-format off includes the template parameters declaration (when it includes just the HPX_CONCEPT_REQUIRES macro, clang-format messes up the alignment of clang-format off and clang-format on comments)

hkaiser previously approved these changes Jul 12, 2020
Copy link

@hkaiser hkaiser left a comment

LGTM otherwise, thanks!

@hkaiser hkaiser added this to Open Tickets in Standard Algorithms Jul 12, 2020
@hkaiser hkaiser moved this from Open Tickets to Work in progress in Standard Algorithms Jul 12, 2020
@hkaiser hkaiser merged commit 4016672 into STEllAR-GROUP:master Jul 13, 2020
17 of 20 checks passed
Standard Algorithms automation moved this from Work in progress to Merged to master Jul 13, 2020
@hkaiser hkaiser added this to the 1.5.0 milestone Jul 13, 2020
@gonidelis gonidelis deleted the foreach_adapt branch Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Standard Algorithms
Merged to master

Successfully merging this pull request may close these issues.

None yet

4 participants