Remove some minor unnecessary CMake options #5185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msimberg
requested review from
aurianer,
biddisco and
hkaiser
as code owners
hkaiser
reviewed
Feb 19, 2021
msimberg
force-pushed
the
cmake-option-cleanup
branch
from
02fd3f5
to
d28aaf2
Compare
msimberg
force-pushed
the
cmake-option-cleanup
branch
from
d28aaf2
to
70fe217
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
HPX_WITH_DEFAULT_TARGETS,HPX_WITH_PSEUDO_DEPENDENCIES,HPX_WITH_MORE_THAN_64_THREADS, andHPX_WITH_NATIVE_TLS. The last two are definitely unnecessary.HPX_WITH_PSEUDO_DEPENDENCIESis always off on Windows, on otherwise, so I've just made it an internal variable.HPX_WITH_DEFAULT_TARGETSI could see someone finding useful so please speak up if you think it should be kept around.