New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt min_element, max_element and minmax_element to C++20 #5241
Conversation
Can one of the admins verify this patch? |
177f713
to
be71e33
Compare
retest |
1 similar comment
retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it took so long to look at this! This looks good to me and can go in. Thanks a lot, good work!
@Jedi18 could you please rebase this onto master for a last time, we'll merge it afterwards. |
1b9120a
to
c1b5a25
Compare
Thanks! Ok done, rebased onto master |
retest |
We now see more errors popping up (e.g. here: https://cdash.cscs.ch/viewBuildError.php?buildid=155130) I think this might be caused by those configurations testing things with HPX_NETWORKONG=OFF and HPX_WITHDISTRIBUTED_RUNTIME=OFF. |
libs/full/segmented_algorithms/tests/unit/partitioned_vector_max_element2.cpp
Show resolved
Hide resolved
retest |
@Jedi18 is the failure here: https://app.circleci.com/pipelines/github/STEllAR-GROUP/hpx/7316/workflows/1cf271c4-1bf8-4ffe-9ce3-d45c4241a24a/jobs/246399/steps something you can reproduce locally? |
6505bd4
to
5762739
Compare
@Jedi18 FWIW, I have squashed all commits and rebased the branch onto master. This should simplify staying up to date in the future. |
a022b05
to
664c43d
Compare
Performance test reportHPX PerformanceComparison
Info
Comparison
Info
Explanation of Symbols
|
Performance test reportHPX PerformanceComparison
Info
Comparison
Info
Explanation of Symbols
|
664c43d
to
6c0c34a
Compare
Performance test reportHPX PerformanceComparison
Info
Comparison
Info
Explanation of Symbols
|
7e00755
to
c5c9b7b
Compare
1168f20
to
70d9d50
Compare
I think this is fine now, the problems have been resolved. Let's wait for the last round of tests to come back and merge if all is green. |
Thanks a lot! I guess the LSU tests aren't running because rostam is down? |
- flyby: more modernization of the min_element, max_element, and minmax_element algorithms
70d9d50
to
9bdd499
Compare
Done.
Yes. |
All right, thanks for looking into that! bors merge |
👎 Rejected by code reviews |
bors merge |
Build succeeded: |
Adapts min_element, max_element and minmax_element to C++20.
Adds min_max_result result type
Add segmented algorithm tests for min_element, max_element and minmax_element
Any background context you want to provide?
#4822
#5156