Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt uninitialized_copy and uninitialized_copy_n to C++ 20 #5371

Merged
merged 15 commits into from Jul 8, 2021

Conversation

Jedi18
Copy link
Contributor

@Jedi18 Jedi18 commented Jun 6, 2021

Adapted uninitialized copy and uninitialized_copy_n to C++ 20 and added container overloads. (range and sentinel). Added container tests.

Any background context you want to provide?

Issue #4822
Issue #3646
Issue #1668

hkaiser
hkaiser previously approved these changes Jun 9, 2021
Copy link
Member

@hkaiser hkaiser left a comment

LGTM, thanks!

hkaiser
hkaiser previously approved these changes Jun 11, 2021
Copy link
Member

@hkaiser hkaiser left a comment

LGTM, thanks!

@hkaiser hkaiser added this to the 1.7.0 milestone Jun 11, 2021
@Jedi18 Jedi18 force-pushed the adapt_uninitialized_copy branch from 8fed8f9 to 782aee8 Compare Jun 18, 2021
@hkaiser
Copy link
Member

hkaiser commented Jun 25, 2021

retest lsu

@Jedi18 Jedi18 force-pushed the adapt_uninitialized_copy branch from 782aee8 to df2918e Compare Jun 26, 2021
@msimberg msimberg removed this from the 1.7.0 milestone Jun 29, 2021
@msimberg
Copy link
Contributor

msimberg commented Jun 30, 2021

retest

@msimberg
Copy link
Contributor

msimberg commented Jun 30, 2021

launch perftests

@hkaiser
Copy link
Member

hkaiser commented Jul 1, 2021

retest lsu

hkaiser
hkaiser previously approved these changes Jul 3, 2021
Copy link
Member

@hkaiser hkaiser left a comment

LGTM, thanks!

@hkaiser
Copy link
Member

hkaiser commented Jul 3, 2021

retest lsu

@msimberg
Copy link
Contributor

msimberg commented Jul 5, 2021

@Jedi18 same here, i.e. this one also needs a rebase after #5389 was merged.

@Jedi18
Copy link
Contributor Author

Jedi18 commented Jul 5, 2021

PR Merge order :- uninitialized_default_construct -> uninitialized_value_construct -> uninitialized_copy -> uninitialized_fill

@msimberg msimberg merged commit fc37a2f into STEllAR-GROUP:master Jul 8, 2021
19 of 33 checks passed
@msimberg msimberg added this to the 1.7.0 milestone Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants