-
-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt uninitialized_move and uninitialized_move_n to C++ 20 #5389
Merged
msimberg
merged 6 commits into
STEllAR-GROUP:master
from
Jedi18:adapt_uninitialized_move
Jul 5, 2021
Merged
Adapt uninitialized_move and uninitialized_move_n to C++ 20 #5389
msimberg
merged 6 commits into
STEllAR-GROUP:master
from
Jedi18:adapt_uninitialized_move
Jul 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jedi18
requested review from
aurianer,
biddisco,
hkaiser and
msimberg
as code owners
June 15, 2021 05:24
Jedi18
force-pushed
the
adapt_uninitialized_move
branch
from
June 18, 2021 16:03
79e7ba4
to
d08678c
Compare
Jedi18
force-pushed
the
adapt_uninitialized_move
branch
from
June 26, 2021 15:41
d08678c
to
0fa1291
Compare
retest |
launch perftests |
hkaiser
reviewed
Jul 1, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/uninitialized_move.hpp
Outdated
Show resolved
Hide resolved
hkaiser
previously approved these changes
Jul 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the minor comment, LGTM, thanks!
hkaiser
approved these changes
Jul 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
retest lsu |
This was referenced Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted uninitialized _move and uninitialized_move_n to C++ 20 and added container overloads. (range and sentinel). Added container tests.
Any background context you want to provide?
Issue #4822
Issue #3646
Issue #1668