-
-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt uninitialized_fill and uninitialized_fill_n to C++ 20 #5402
Adapt uninitialized_fill and uninitialized_fill_n to C++ 20 #5402
Conversation
libs/parallelism/algorithms/include/hpx/parallel/algorithms/uninitialized_fill.hpp
Show resolved
Hide resolved
libs/parallelism/algorithms/include/hpx/parallel/algorithms/uninitialized_fill.hpp
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, LGTM! Thanks!
6cab4ff
to
9acb7dd
Compare
retest |
launch perftests |
@Jedi18 something is not quite right here. The failing tests do normally pass. This PR needs more investigation. |
@hkaiser Thanks, I'll look into it |
9acb7dd
to
6f033c8
Compare
PR Merge order :- uninitialized_default_construct -> uninitialized_value_construct -> uninitialized_copy -> uninitialized_fill |
6f033c8
to
e7d4f8b
Compare
Adapted uninitialized _fill and uninitialized_fill_n to C++ 20 and added container overloads. (range and sentinel). Added container tests.
Any background context you want to provide?
Issue #4822
Issue #3646
Issue #1668