Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt uninitialized_fill and uninitialized_fill_n to C++ 20 #5402

Merged
merged 13 commits into from Jul 8, 2021

Conversation

Jedi18
Copy link
Contributor

@Jedi18 Jedi18 commented Jun 19, 2021

Adapted uninitialized _fill and uninitialized_fill_n to C++ 20 and added container overloads. (range and sentinel). Added container tests.

Any background context you want to provide?

Issue #4822
Issue #3646
Issue #1668

hkaiser
hkaiser previously approved these changes Jun 25, 2021
Copy link
Member

@hkaiser hkaiser left a comment

Otherwise, LGTM! Thanks!

@Jedi18 Jedi18 force-pushed the adapt_uninitialized_fill branch from 6cab4ff to 9acb7dd Compare Jun 26, 2021
@msimberg msimberg removed this from the 1.7.0 milestone Jun 29, 2021
@msimberg
Copy link
Contributor

msimberg commented Jun 30, 2021

retest

@msimberg
Copy link
Contributor

msimberg commented Jun 30, 2021

launch perftests

@hkaiser
Copy link
Member

hkaiser commented Jul 3, 2021

@Jedi18 something is not quite right here. The failing tests do normally pass. This PR needs more investigation.

@Jedi18
Copy link
Contributor Author

Jedi18 commented Jul 4, 2021

@hkaiser Thanks, I'll look into it

@msimberg
Copy link
Contributor

msimberg commented Jul 5, 2021

Given that the failing tests are compilation tests and they time out, it may have nothing to do with this PR. However, this would need rebasing now that I merged #5389. @Jedi18 would you mind doing that, and then my guess is that the now failing tests won't fail anymore.

@Jedi18 Jedi18 force-pushed the adapt_uninitialized_fill branch from 9acb7dd to 6f033c8 Compare Jul 5, 2021
@Jedi18
Copy link
Contributor Author

Jedi18 commented Jul 5, 2021

PR Merge order :- uninitialized_default_construct -> uninitialized_value_construct -> uninitialized_copy -> uninitialized_fill

@Jedi18 Jedi18 force-pushed the adapt_uninitialized_fill branch from 6f033c8 to e7d4f8b Compare Jul 6, 2021
@msimberg msimberg merged commit 0ddd24f into STEllAR-GROUP:master Jul 8, 2021
27 of 33 checks passed
@msimberg msimberg added this to the 1.7.0 milestone Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants