Adapt uninitialized_fill and uninitialized_fill_n to C++ 20#5402
Merged
msimberg merged 13 commits intoSTEllAR-GROUP:masterfrom Jul 8, 2021
Merged
Adapt uninitialized_fill and uninitialized_fill_n to C++ 20#5402msimberg merged 13 commits intoSTEllAR-GROUP:masterfrom
msimberg merged 13 commits intoSTEllAR-GROUP:masterfrom
Conversation
Jedi18
requested review from
aurianer,
biddisco,
hkaiser and
msimberg
as code owners
hkaiser
reviewed
Jun 25, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/uninitialized_fill.hpp
Show resolved
Hide resolved
hkaiser
reviewed
Jun 25, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/uninitialized_fill.hpp
Show resolved
Hide resolved
Jedi18
force-pushed
the
adapt_uninitialized_fill
branch
from
6cab4ff to
9acb7dd
Compare
Contributor
|
retest |
Contributor
|
launch perftests |
Member
|
@Jedi18 something is not quite right here. The failing tests do normally pass. This PR needs more investigation. |
Contributor
Author
|
@hkaiser Thanks, I'll look into it |
Contributor
Jedi18
force-pushed
the
adapt_uninitialized_fill
branch
from
9acb7dd to
6f033c8
Compare
Contributor
Author
|
PR Merge order :- uninitialized_default_construct -> uninitialized_value_construct -> uninitialized_copy -> uninitialized_fill |
Jedi18
force-pushed
the
adapt_uninitialized_fill
branch
from
6f033c8 to
e7d4f8b
Compare
Jedi18
commented
Jul 8, 2021
This was referenced Jul 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapted uninitialized _fill and uninitialized_fill_n to C++ 20 and added container overloads. (range and sentinel). Added container tests.
Any background context you want to provide?
Issue #4822
Issue #3646
Issue #1668