Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt exclusive_scan to C++20 #5436

Merged
merged 11 commits into from Jul 30, 2021
Merged

Conversation

Jedi18
Copy link
Contributor

@Jedi18 Jedi18 commented Jul 7, 2021

Adapted exclusive_scan to C++ 20 and added container overloads. (range and sentinel). Added container tests. Seperated segmented overloads.

Any background context you want to provide?

Issue #4822
Issue #3646
Issue #1668
Issue #5156

@Jedi18
Copy link
Contributor Author

Jedi18 commented Jul 11, 2021

@hkaiser Why is this issue's type breaking change?

@hkaiser
Copy link
Member

hkaiser commented Jul 11, 2021

@hkaiser Why is this issue's type breaking change?

My mistake, thanks for spotting!

Copy link
Member

@hkaiser hkaiser left a comment

Nicely done! Thanks!

@jenkins-cscs
Copy link
Collaborator

jenkins-cscs commented Jul 26, 2021

Can one of the admins verify this patch?

hkaiser
hkaiser previously approved these changes Jul 26, 2021
Copy link
Member

@hkaiser hkaiser left a comment

LGTM, thanks!

@hkaiser
Copy link
Member

hkaiser commented Jul 30, 2021

@Jedi18 After merging one of the other algorithm PRs this one (and others) has conflicts. Could you fix those, please?

@Jedi18
Copy link
Contributor Author

Jedi18 commented Jul 30, 2021

@hkaiser Sure, I'll rebase them on top of each other so we don't have to fix conflicts for every merge.

@Jedi18
Copy link
Contributor Author

Jedi18 commented Jul 30, 2021

Merge order - exlcusive_scan -> transform_exclusive_scan -> tranform_inclusive_scan

@hkaiser hkaiser merged commit 4db64cd into STEllAR-GROUP:master Jul 30, 2021
23 of 30 checks passed
Standard Algorithms automation moved this from Open Tickets to Merged to master Jul 30, 2021
@hkaiser hkaiser mentioned this pull request Jul 30, 2021
9 tasks
@msimberg msimberg modified the milestones: 1.8.0, 1.7.1 Aug 6, 2021
msimberg pushed a commit that referenced this pull request Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Standard Algorithms
  
Merged to master
Development

Successfully merging this pull request may close these issues.

None yet

4 participants