Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt exclusive_scan to C++20 #5436

Merged
merged 11 commits into from Jul 30, 2021
Merged

Conversation

@Jedi18
Copy link
Contributor

@Jedi18 Jedi18 commented Jul 7, 2021

Adapted exclusive_scan to C++ 20 and added container overloads. (range and sentinel). Added container tests. Seperated segmented overloads.

Any background context you want to provide?

Issue #4822
Issue #3646
Issue #1668
Issue #5156

@Jedi18 Jedi18 force-pushed the Jedi18:adapt_exclusive_scan branch 5 times, most recently from 2130384 to 0856684 Jul 7, 2021
@Jedi18 Jedi18 force-pushed the Jedi18:adapt_exclusive_scan branch from 0856684 to ab04639 Jul 10, 2021
@hkaiser hkaiser added this to the 1.8.0 milestone Jul 11, 2021
@hkaiser hkaiser added this to Open Tickets in Standard Algorithms via automation Jul 11, 2021
@Jedi18
Copy link
Contributor Author

@Jedi18 Jedi18 commented Jul 11, 2021

@hkaiser Why is this issue's type breaking change?

@hkaiser
Copy link
Member

@hkaiser hkaiser commented Jul 11, 2021

@hkaiser Why is this issue's type breaking change?

My mistake, thanks for spotting!

@hkaiser hkaiser mentioned this pull request Jul 15, 2021
41 of 45 tasks
Copy link
Member

@hkaiser hkaiser left a comment

Nicely done! Thanks!

@Jedi18 Jedi18 force-pushed the Jedi18:adapt_exclusive_scan branch from ab04639 to 288961b Jul 22, 2021
@Jedi18 Jedi18 force-pushed the Jedi18:adapt_exclusive_scan branch from de99924 to 99de280 Jul 23, 2021
@jenkins-cscs
Copy link
Collaborator

@jenkins-cscs jenkins-cscs commented Jul 26, 2021

Can one of the admins verify this patch?

Copy link
Member

@hkaiser hkaiser left a comment

LGTM, thanks!

@hkaiser
Copy link
Member

@hkaiser hkaiser commented Jul 30, 2021

@Jedi18 After merging one of the other algorithm PRs this one (and others) has conflicts. Could you fix those, please?

@Jedi18
Copy link
Contributor Author

@Jedi18 Jedi18 commented Jul 30, 2021

@hkaiser Sure, I'll rebase them on top of each other so we don't have to fix conflicts for every merge.

@Jedi18 Jedi18 force-pushed the Jedi18:adapt_exclusive_scan branch from 99de280 to 874d8de Jul 30, 2021
@Jedi18
Copy link
Contributor Author

@Jedi18 Jedi18 commented Jul 30, 2021

Merge order - exlcusive_scan -> transform_exclusive_scan -> tranform_inclusive_scan

@hkaiser hkaiser merged commit 4db64cd into STEllAR-GROUP:master Jul 30, 2021
23 of 30 checks passed
23 of 30 checks passed
@github-actions
build build
Details
@github-actions
build
Details
@github-actions
build
Details
@github-actions
build
Details
@github-actions
build
Details
@github-actions
build
Details
@github-actions
build
Details
@circleci-checks
build-and-test Workflow: build-and-test
Details
@jenkins-cscs
jenkins/cscs-perftests Build finished.
Details
@msimberg
jenkins/lsu/gcc-8-debug Jenkins
Details
@msimberg
jenkins/lsu/gcc-8-release Jenkins
Details
@msimberg
jenkins/lsu/gcc-9-cuda-11-debug Jenkins
Details
@msimberg
jenkins/lsu/gcc-9-cuda-11-release Jenkins
Details
@codacy-production
Codacy Static Code Analysis A positive pull request.
Details
@jenkins-cscs
jenkins/cscs Build finished.
Details
@msimberg
jenkins/cscs/clang-10 Jenkins
Details
@msimberg
jenkins/cscs/clang-8 Jenkins
Details
@msimberg
jenkins/cscs/clang-9 Jenkins
Details
@msimberg
jenkins/cscs/clang-apex Jenkins
Details
@msimberg
jenkins/cscs/clang-cuda Jenkins
Details
@msimberg
jenkins/cscs/clang-newest Jenkins
Details
@msimberg
jenkins/cscs/clang-oldest Jenkins
Details
@msimberg
jenkins/cscs/gcc-10 Jenkins
Details
@msimberg
jenkins/cscs/gcc-cuda Jenkins
Details
@msimberg
jenkins/cscs/gcc-newest Jenkins
Details
@msimberg
jenkins/cscs/gcc-oldest Jenkins
Details
@msimberg
jenkins/lsu/clang-9-debug Jenkins
Details
@msimberg
jenkins/lsu/clang-9-release Jenkins
Details
@msimberg
jenkins/lsu/gcc-9-debug Jenkins
Details
@msimberg
jenkins/lsu/gcc-9-release Jenkins
Details
Standard Algorithms automation moved this from Open Tickets to Merged to master Jul 30, 2021
@hkaiser hkaiser mentioned this pull request Jul 30, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Standard Algorithms
  
Merged to master
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants